New issue
Advanced search Search tips

Issue 724115 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

CVC sheet improvements

Project Member Reported by anthonyvd@chromium.org, May 18 2017

Issue description

The CVC unmask sheet should use CreateCvcTextfield and display the error label with a warning icon.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f3f0a30655f4b8e6a4a58a2bd8a88ac9f600f5d

commit 2f3f0a30655f4b8e6a4a58a2bd8a88ac9f600f5d
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Sun May 21 17:44:04 2017

[Web Payments] Disable Done in CVC unmask prompt when CVC is invalid

Bug:  724115 
Change-Id: Iff1d849ad91690613f0da156a33d50e15ed8ef0e
Reviewed-on: https://chromium-review.googlesource.com/510049
Commit-Queue: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473476}
[modify] https://crrev.com/2f3f0a30655f4b8e6a4a58a2bd8a88ac9f600f5d/chrome/browser/ui/views/payments/cvc_unmask_view_controller.cc
[modify] https://crrev.com/2f3f0a30655f4b8e6a4a58a2bd8a88ac9f600f5d/chrome/browser/ui/views/payments/cvc_unmask_view_controller.h
[modify] https://crrev.com/2f3f0a30655f4b8e6a4a58a2bd8a88ac9f600f5d/chrome/browser/ui/views/payments/cvc_unmask_view_controller_browsertest.cc
[modify] https://crrev.com/2f3f0a30655f4b8e6a4a58a2bd8a88ac9f600f5d/chrome/browser/ui/views/payments/payment_request_browsertest_base.cc
[modify] https://crrev.com/2f3f0a30655f4b8e6a4a58a2bd8a88ac9f600f5d/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc
[modify] https://crrev.com/2f3f0a30655f4b8e6a4a58a2bd8a88ac9f600f5d/chrome/browser/ui/views/payments/payment_request_sheet_controller.h
[modify] https://crrev.com/2f3f0a30655f4b8e6a4a58a2bd8a88ac9f600f5d/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
[modify] https://crrev.com/2f3f0a30655f4b8e6a4a58a2bd8a88ac9f600f5d/chrome/browser/ui/views/payments/payment_sheet_view_controller.h

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2f2f59ba8bb051466d75ebc75eeec2ac301f1fb

commit c2f2f59ba8bb051466d75ebc75eeec2ac301f1fb
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Wed Jun 21 22:15:52 2017

[Web Payments] Add an icon to CVC unmask error label.

Bug:  724115 
Change-Id: I55b404b83f4b4e1ec9f8470a2e45732433def943
Reviewed-on: https://chromium-review.googlesource.com/542960
Commit-Queue: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481328}
[modify] https://crrev.com/c2f2f59ba8bb051466d75ebc75eeec2ac301f1fb/chrome/browser/ui/views/payments/cvc_unmask_view_controller.cc
[modify] https://crrev.com/c2f2f59ba8bb051466d75ebc75eeec2ac301f1fb/chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h

Components: -UI>Browser>Autofill>Payments UI>Browser>Payments
Status: Fixed (was: Assigned)

Sign in to add a comment