New issue
Advanced search Search tips

Issue 724105 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

3.1% regression in speedometer at 472425:472431

Project Member Reported by tdres...@chromium.org, May 18 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=724105

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgmsjQ4wkM


Bot(s) for this bug's original alert(s):

android-webview-nexus6
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, May 19 2017

Cc: delph...@chromium.org
Owner: delph...@chromium.org

=== Auto-CCing suspected CL author delphick@chromium.org ===

Hi delphick@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : delphick
  Commit : f5065232010251bad1cccddcc2a0d27ac2232f67
  Date   : Wed May 17 12:00:59 2017
  Subject: Schedule bitmap animation timers on the compositor task runner.

Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : speedometer
  Metric       : Total/Total
  Change       : 3.77% | 25576.5941667 -> 26540.0566667

Revision             Result                  N
chromium@472424      25576.6 +- 224.866      6      good
chromium@472426      25776.8 +- 233.444      6      good
chromium@472427      26318.8 +- 217.579      6      bad       <--
chromium@472428      26512.2 +- 310.434      6      bad
chromium@472431      26540.1 +- 342.575      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests speedometer

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8979248555642793360

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5323687449853952


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, May 20 2017

 Issue 724129  has been merged into this issue.
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, May 20 2017

 Issue 724194  has been merged into this issue.
This was rolled back on Friday.
Status: Assigned (was: Untriaged)
Explictly assigning. A CL you landed tripped one of the speed metrics we measure in the lab. If this is the first time this has happened to one of your CLs, or if it's been a while, please read: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/addressing_performance_regressions.md

We're looking for one of the following:
1. Justification via explanation
2. Plan to revert or fix
3. Angry rage throwing of equipment at my head

Just be aware that I'm trained in trumpet playing and First Aid and am not afraid to use it.

Note: This was a bulk edit message and not very personal.
Status: Fixed (was: Assigned)
I doubt this tripped anything recently since it was rolled back in May.

Sign in to add a comment