New issue
Advanced search Search tips

Issue 724084 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

OOM in V8 on GPU FYI Linux Intel Release on some deqp_functional_gles3_texturefiltering tests

Project Member Reported by cwallez@chromium.org, May 18 2017

Issue description

The tests crash with an OOM in some v8 code. There are two v8 rolls in the regression range and I didn't find other suspicious commits.

The failures started in this build https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28Intel%20HD%20530%29/builds/617

The v8 rolls:
https://chromium.googlesource.com/v8/v8/+log/309a9310..942ddf2c
https://chromium.googlesource.com/v8/v8/+log/942ddf2c..04ea83be

Tentatively assigning to bmeurer@, to my untrained eyes the "[turbofan] Always inline small functions directly." commit looks like it could be causing the issue: this dEQP test contains many many small functions.

The stack trace
[1:33:0517/232739.015875:FATAL:memory_linux.cc(35)] Out of memory.
#0 0x55a7d88a7ac7 base::debug::StackTrace::StackTrace()
#1 0x55a7d88c16cd logging::LogMessage::~LogMessage()
#2 0x55a7d88e869e base::(anonymous namespace)::OnNoMemory()
#3 0x55a7d894ac29 GlibcMallocHook
#4 0x55a7d817eb0f v8::internal::AccountingAllocator::GetSegment()
#5 0x55a7d817f064 v8::internal::Zone::NewExpand()
#6 0x55a7d817ef40 v8::internal::Zone::New()
#7 0x55a7d7afd138 v8::internal::compiler::BranchElimination::ReduceDeoptimizeConditional()
#8 0x55a7d7b457c2 v8::internal::compiler::GraphReducer::ReduceTop()
#9 0x55a7d7b451a8 v8::internal::compiler::GraphReducer::ReduceNode()
#10 0x55a7d7bf02af v8::internal::compiler::LateOptimizationPhase::Run()
#11 0x55a7d7be8198 v8::internal::compiler::PipelineImpl::OptimizeGraph()
#12 0x55a7d7be7c64 v8::internal::compiler::PipelineCompilationJob::ExecuteJobImpl()
#13 0x55a7d7ad7e3e v8::internal::CompilationJob::ExecuteJob()
#14 0x55a7d7ad6748 v8::internal::OptimizingCompileDispatcher::CompileNext()
#15 0x55a7d7ad7948 v8::internal::OptimizingCompileDispatcher::CompileTask::Run()
#16 0x55a7d6b65951 _ZNO4base8CallbackIFvvELNS_8internal8CopyModeE1ELNS2_10RepeatModeE1EE3RunEv
#17 0x55a7d8968dc7 base::(anonymous namespace)::WorkerThread::ThreadMain()
#18 0x55a7d8915e5c base::(anonymous namespace)::ThreadFunc()
#19 0x7f1d24d606ca start_thread
#20 0x7f1d1e75f0af clone
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/d652d06f887b9ab062a0ab1bb697beef4a823a81

commit d652d06f887b9ab062a0ab1bb697beef4a823a81
Author: bmeurer <bmeurer@chromium.org>
Date: Fri May 19 04:25:54 2017

[turbofan] Add absolute upper bound for small function inlining.

Introduce a flag --max-inlined-nodes-absolute that is used to limit the
number of nodes that we inline even in the presence of small function
inlining, so that TurboFan graphs don't grow arbitrary large.

BUG= chromium:724084 , v8:6395 ,v8:6278,v8:6344,v8:6394
TBR=mvstanton@chromium.org

Review-Url: https://codereview.chromium.org/2894523005
Cr-Commit-Position: refs/heads/master@{#45414}

[modify] https://crrev.com/d652d06f887b9ab062a0ab1bb697beef4a823a81/src/compiler/js-inlining-heuristic.cc
[modify] https://crrev.com/d652d06f887b9ab062a0ab1bb697beef4a823a81/src/flag-definitions.h

Status: Fixed (was: Assigned)

Sign in to add a comment