New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 724083 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

HistogramTester using histograms.xml.

Project Member Reported by tdres...@chromium.org, May 18 2017

Issue description

I'm always paranoid that my histograms.xml entries will be incorrect somehow, and it seems to happen pretty frequently (e.g. here).

This wouldn't happen if HistogramTester parsed histograms.xml, and didn't let you read histogram entries that weren't included in histograms.xml.



 
Alexei or Rob, any thoughts on whether this would be worth doing?
Labels: -OS-Linux OS-All
It doesn't seem unreasonable. We already have a test that does something like this - AboutFlagsHistogramTest.CheckHistograms - which checks that all the entries in about_flags are included in the XML enums.

One thing worth noting is that there are histograms that are only documented internally - but they're a tiny minority of them - and maybe don't use the tester infrastructure.

Sign in to add a comment