New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 724079 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
NOT IN USE
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

10.1%-10.4% regression in blink_perf.layout at 471121:471248

Project Member Reported by tdres...@chromium.org, May 18 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, May 18 2017


=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: mac_air_perf_bisect
  Benchmark    : blink_perf.layout
  Metric       : floats_10_1000/floats_10_1000

Revision             Result                 N
chromium@471179      724.1 +- 97.4818       21      good
chromium@471248      729.093 +- 127.76      21      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.layout

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8979252291836579920

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6431111749566464


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, May 19 2017


=== BISECT JOB RESULTS ===
Perf regression found but unable to narrow commit range

Build failures prevented the bisect from narrowing the range further.


Bisect Details
  Configuration: mac_air_perf_bisect
  Benchmark    : blink_perf.layout
  Metric       : floats_10_1000/floats_10_1000
  Change       : 3.59% | 711.525444444 -> 735.2965

Suspected Commit Range
  2 commits in range
  https://chromium.googlesource.com/chromium/src/+log/47778d3b6f6e5da0a698689d9c4c3e7e3cf0f51e..5e53c60ebe374282c8c2864a8e6d1d864afa221a


Revision             Result                  N
chromium@471179      711.525 +- 12.7817      9        good
chromium@471184      714.085 +- 21.9876      9        good
chromium@471186      717.579 +- 26.05        14       good
chromium@471187      ---                     ---      build failure
chromium@471188      723.614 +- 23.3864      14       bad
chromium@471197      729.177 +- 20.5878      6        bad
chromium@471214      722.246 +- 20.2556      8        bad
chromium@471248      735.297 +- 30.337       6        bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.layout

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8979220191963514400

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6431111749566464


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Owner: r...@opera.com
rune: the build before yours failed, so we can't be certain, but it looks like there is a regression in blink_perf.layout at r471188. Can you take a look?

Comment 7 by r...@opera.com, May 22 2017

Looking at "All the graphs for this bug", it looks to me like it recovered.

Comment 8 by r...@opera.com, May 24 2017

Status: WontFix (was: Untriaged)
I've run flexbox-column-wrap and flexbox-column-nowrap locally on Linux with a recent master, and with the suspected CL reverted off that master without being able to reproduce the regression. The floats_10_1000 was reported for mac_air and the graph is clearly recovered and showing better results than before the regression.

Closing.

Sign in to add a comment