New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 724053 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit 15 days ago
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1% regression in system_health.memory_mobile at 471418:471487

Project Member Reported by tdres...@chromium.org, May 18 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=724053

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgmpqD6AkM


Bot(s) for this bug's original alert(s):

android-webview-nexus5X
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, May 19 2017

Cc: binji@chromium.org
Owner: binji@chromium.org

=== Auto-CCing suspected CL author binji@chromium.org ===

Hi binji@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : binji
  Commit : e94f5343100836bcdc838dc4da4fd13d4c69a950
  Date   : Fri May 12 22:16:05 2017
  Subject: Enable SharedArrayBuffer feature by default.

Bisect Details
  Configuration: android_webview_arm64_aosp_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:webview:all_processes:reported_by_chrome:v8:effective_size_avg/background_social/background_social_facebook
  Change       : 0.77% | 3045712.0 -> 3069176.0

Revision             Result                  N
chromium@471417      3045712 +- 0.0          6      good
chromium@471452      3045712 +- 0.0          6      good
chromium@471457      3045640 +- 394.36       6      good
chromium@471459      3045712 +- 0.0          6      good
chromium@471460      3069320 +- 0.0          6      bad       <--
chromium@471461      3069248 +- 394.36       6      bad
chromium@471470      3069248 +- 394.36       6      bad
chromium@471487      3069176 +- 498.831      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=background.social.facebook system_health.memory_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8979256144462316320

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5343376653680640


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, May 22 2017

Cc: jochen@chromium.org
 Issue 725009  has been merged into this issue.
Status: Assigned (was: Untriaged)
Ben, can you take a look at this?
Any idea why this would impact android memory?

Comment 6 by binji@chromium.org, Jun 8 2017

This looks likely to be the additional builtins/codestubs for Atomics and SharedArrayBuffer per native context. I tried to find any other reason for the size increase, but this seems to be it. Unfortunately, I'm not sure there's much else that can be done here.
Cc: danno@chromium.org bradnelson@chromium.org
Given the above, I would venture that we should mark this as WontFix, bradnelson@, danno@ WDYT?

Comment 8 by binji@chromium.org, Jun 13 2017

Thanks to some suggestions from adamk, I was able to find that the heap size is larger than it should be. It won't completely remove the size increase (since that is just what happens we add new builtins) but it should make it a little better.

Gonna work on that CL today.
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/284a4804f2f2cab172d2b4d96048b5d8986c72cd

commit 284a4804f2f2cab172d2b4d96048b5d8986c72cd
Author: Ben Smith <binji@chromium.org>
Date: Tue Jun 13 23:45:44 2017

[SAB] Move creation of SharedArrayBuffer/Atomics to InitializeGlobal

It is only attached to the global object if the --harmony-sharedarraybuffer
flag is enabled, but this allows more objects to be added to the snapshot which
seems to reduce the amount of heap memory used per context.

Bug:  chromium:724053 
Change-Id: I5d1115a0e3ed9abf41cb3ab80d19d622cbef7b93
Reviewed-on: https://chromium-review.googlesource.com/534594
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Ben Smith <binji@chromium.org>
Cr-Commit-Position: refs/heads/master@{#45930}
[modify] https://crrev.com/284a4804f2f2cab172d2b4d96048b5d8986c72cd/src/bootstrapper.cc
[modify] https://crrev.com/284a4804f2f2cab172d2b4d96048b5d8986c72cd/src/contexts.h

Comment 10 by binji@chromium.org, Jun 13 2017

OK, landed. I'll take a look at the perf charts in a day or two to see if this improved the regression.

Comment 11 by binji@google.com, Jun 15 2017

OK, this change seems to have improved all of the memory graphs. The previous graph increased by about 23k, this change reduces it by 13k, for a net increase of ~10k. Unfortunately, there is a much larger memory regression ( https://crbug.com/729228 ), so the absolute ending memory usage is up by quite a bit more.

Comment 12 by binji@chromium.org, Jun 15 2017

 Issue 724056  has been merged into this issue.

Comment 13 by binji@chromium.org, Jun 15 2017

Issue 724969 has been merged into this issue.

Comment 14 by binji@chromium.org, Jun 16 2017

Labels: Merge-Request-60
Project Member

Comment 15 by sheriffbot@chromium.org, Jun 16 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Please add appropriate OSs.  Thanks.

Comment 17 by binji@chromium.org, Jun 19 2017

Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Labels: -Merge-Review-60 Merge-Rejected-60
Rejected for M60 branch 3112 - it's not a huge regression, and the fix is not small.
Status: Fixed (was: Assigned)
Closing as fixed; binji, please reopen if I made a mistake?

Sign in to add a comment