New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 724045 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.1%-16.3% regression in memory.top_10_mobile at 472325:472369

Project Member Reported by tdres...@chromium.org, May 18 2017

Issue description

See the link to graphs below.
 
Cc: neis@chromium.org
 Issue 724044  has been merged into this issue.
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, May 19 2017

Cc: wiktorg@google.com
Owner: wiktorg@google.com

=== Auto-CCing suspected CL author wiktorg@google.com ===

Hi wiktorg@google.com, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Wiktor Garbacz
  Commit : ce538f70c12864fe700c716b991fa57c5693ff4f
  Date   : Tue May 16 11:34:41 2017
  Subject: [parser] Refactor streaming scanner streams.

Bisect Details
  Configuration: android_webview_arm64_aosp_perf_bisect
  Benchmark    : memory.top_10_mobile
  Metric       : memory:webview:all_processes:reported_by_chrome:cc:effective_size_avg/foreground/http_yandex_ru_touchsearch_text_science
  Change       : 16.57% | 11767200.0 -> 13716896.0

Revision                           Result                  N
chromium@472343                    11767200 +- 140464      6      good
chromium@472347                    11748085 +- 132430      6      good
chromium@472347,v8@1972e37392      11767200 +- 140464      6      good
chromium@472347,v8@e418a1e4f3      11786315 +- 132430      6      good
chromium@472347,v8@ce538f70c1      13755125 +- 193049      6      bad       <--
chromium@472347,v8@04ac13deef      13734181 +- 201465      6      bad
chromium@472347,v8@e92c52ba8a      13695952 +- 126332      6      bad
chromium@472348                    13753296 +- 185556      6      bad
chromium@472349                    13678667 +- 104695      6      bad
chromium@472350                    13695952 +- 126332      6      bad
chromium@472356                    13678667 +- 104695      6      bad
chromium@472369                    13716896 +- 140464      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8979257027989464528

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5693342299455488


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, May 19 2017

 Issue 724112  has been merged into this issue.
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, May 21 2017


=== BISECT JOB RESULTS ===
Bisect was unable to run to completion

Error: TIMEOUT

The bisect was able to narrow the range, you can try running with:
  good_revision: d1ada059c7362462bf72dc44c103db994362d9c3
  bad_revision : a69853688927b512a65e2fa3ce267bba70e51747

If failures persist contact the team (see below) and report the error.


Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : memory.top_10_mobile
  Metric       : memory:webview:all_processes:reported_by_chrome:cc:effective_size_avg/foreground/http_yandex_ru_touchsearch_text_science
  Change       : 14.85% | 22834512.0 -> 26226000.0

Revision             Result                  N
chromium@472338      22834512 +- 340535      6      good
chromium@472346      22785360 +- 269217      6      good
chromium@472348      26226000 +- 340535      6      bad
chromium@472350      26176848 +- 269217      6      bad
chromium@472354      26226000 +- 340535      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8979166468984259120

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5786270862671872


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, May 22 2017


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Wiktor Garbacz
  Commit : ce538f70c12864fe700c716b991fa57c5693ff4f
  Date   : Tue May 16 11:34:41 2017
  Subject: [parser] Refactor streaming scanner streams.

Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : memory.top_10_mobile
  Metric       : memory:webview:all_processes:reported_by_chrome:cc:effective_size_avg/foreground/http_yandex_ru_touchsearch_text_science
  Change       : 14.36% | 22932816.0 -> 26226000.0

Revision                           Result                  N
chromium@472338                    22932816 +- 340535      6      good
chromium@472346                    22932816 +- 340535      6      good
chromium@472347                    22785360 +- 269217      6      good
chromium@472347,v8@1972e37392      22932816 +- 340535      6      good
chromium@472347,v8@e418a1e4f3      22834512 +- 340535      6      good
chromium@472347,v8@ce538f70c1      26275152 +- 361192      6      bad       <--
chromium@472347,v8@04ac13deef      26324304 +- 340535      6      bad
chromium@472347,v8@e92c52ba8a      26324304 +- 340535      6      bad
chromium@472348                    26324304 +- 340535      6      bad
chromium@472350                    26324304 +- 340535      6      bad
chromium@472354                    26226000 +- 340535      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8978982377536567040

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5786270862671872


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Status: Fixed (was: Untriaged)
Closing this since the commit was reverted (for other reasons).

Sign in to add a comment