New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 724031 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Merge PacketBuffer H264 fix to M59

Project Member Reported by philipel@chromium.org, May 18 2017

Issue description

In some cases receiving a H264 stream will cause an infinite loop in the PacketBuffer.

Fix has been landed here: https://codereview.chromium.org/2868723003/
 
Project Member

Comment 1 by sheriffbot@chromium.org, May 19 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 2 by bugdroid1@chromium.org, May 22 2017

Labels: merge-merged-59
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/2996dc5a520cbe2051d401dfce5ee4800162007f

commit 2996dc5a520cbe2051d401dfce5ee4800162007f
Author: philipel <philipel@webrtc.org>
Date: Mon May 22 12:13:22 2017

Break backwards traversal loop if we have looped around all packets in the PacketBuffer for H264 frames.

BUG= webrtc:7532 ,  chromium:724031 
R=holmer@google.com

Review-Url: https://codereview.webrtc.org/2868723003
Cr-Original-Commit-Position: refs/heads/master@{#18191}
Review-Url: https://codereview.webrtc.org/2899713002 .
Cr-Commit-Position: refs/branch-heads/59@{#12}
Cr-Branched-From: 10d095d4f743bc16f8e486e156c48a6d023b32c5-refs/heads/master@{#17657}

[modify] https://crrev.com/2996dc5a520cbe2051d401dfce5ee4800162007f/webrtc/modules/video_coding/packet_buffer.cc
[modify] https://crrev.com/2996dc5a520cbe2051d401dfce5ee4800162007f/webrtc/modules/video_coding/video_packet_buffer_unittest.cc

Project Member

Comment 3 by sheriffbot@chromium.org, May 22 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Approved -Merge-Approved-59
Status: Fixed (was: Assigned)

Sign in to add a comment