The web page is translated to english though it is not set to always translate. |
|||
Issue descriptionApp Version: 59.0.3071.59 dev iOS Version: 10.3.1, 10.2.1 Device: iPhone, iPad URL: baidu.com, qq.com Steps to reproduce: 1. Launch chrome and load baidu.com 2. Tap on Translate button 3. Set always translate toggle button to “on” 4. Tap on the (X) icon in the info bar (which means always translate is not agreed) 5. Open new tab and load qq.com Observed results: At step 4. The always translate option is saved At step 5. Notice the webpage qq.com is translated to english though the done is not tapped at step4. Expected results: Always translate should be saved when only tap on “done” button. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: No Bug reproducible on Firefox/Safari: Firefox: NA, Safari:NA Bug reproducible on current stable build (App Version, iOS Version): Yes on M58 Bug reproducible on the current beta channel build (App Version, iOS Version): Yes on M59 Link to video/image: iOS behavior: https://drive.google.com/a/google.com/file/d/0B8Cek8RsDbF8bmtWUFVPZDJNZVE/view?usp=sharing Android behavior: https://drive.google.com/a/google.com/file/d/0B8Cek8RsDbF8Q3gzNkhZWnR5WGs/view?usp=sharing
,
Jun 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce876098aaad374c15b215c6b2d668436a9dbcba commit ce876098aaad374c15b215c6b2d668436a9dbcba Author: Sylvain Defresne <sdefresne@chromium.org> Date: Thu Jun 01 11:33:29 2017 [ios] Only save "Always translate" setting when using "Done". The state of "Always translate" should only be saved if the user validate the change by using the "Done" button, so use a variable to store the interaction and update the model when user taps on the "Done" button. BUG= 724030 Change-Id: I421b274d3f067e569923731f7359348ab1948063 Reviewed-on: https://chromium-review.googlesource.com/519149 Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#476251} [modify] https://crrev.com/ce876098aaad374c15b215c6b2d668436a9dbcba/ios/chrome/browser/translate/after_translate_infobar_controller.mm
,
Jun 1 2017
,
Jun 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1704affd92a33a48072fa0dfb0a63af1853a493a commit 1704affd92a33a48072fa0dfb0a63af1853a493a Author: Sylvain Defresne <sdefresne@chromium.org> Date: Thu Jun 01 16:44:24 2017 [ios] Fix testTranslateInfobar EarlGrey test. The setting is only saved when the "Done" button is tapped, so update the test to confirm this. BUG= 724030 Change-Id: Ia274bd3cf4058c766ef8dfa0b2e05279d34021e5 Reviewed-on: https://chromium-review.googlesource.com/521108 Commit-Queue: Jean-François Geyelin <jif@chromium.org> Reviewed-by: Jean-François Geyelin <jif@chromium.org> Cr-Commit-Position: refs/heads/master@{#476323} [modify] https://crrev.com/1704affd92a33a48072fa0dfb0a63af1853a493a/ios/chrome/browser/translate/translate_egtest.mm
,
Jun 6 2017
Verified in 61.0.3122.0 canary iPhone 6 plus iOS 10.2.1, iPad mini 10.3.3 Looks good. |
|||
►
Sign in to add a comment |
|||
Comment 1 by kkhorimoto@chromium.org
, May 18 2017Status: Assigned (was: Untriaged)