Highlight of a single search results flickers on F3
Reported by
mr.ber...@gmail.com,
May 18 2017
|
|||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36 Steps to reproduce the problem: 1. chrome://version/ 2. F3, "JavaScript" (is found and highlighted) 3. Press F3 and keep pressed What is the expected behavior? Not much What went wrong? Highlight flickers Did this work before? N/A Chrome version: 58.0.3029.110 Channel: stable OS Version: 10.0 Flash Version: IE11 does not do this.
,
May 19 2017
Tested the issue on windows 10 using M58 #58.0.3029.110 and and on F3 we cannot see any javascript. @mr.berker-- Could you please provide detailed steps to reproduce the issue and also please provide us the screencast of the issue. Thanks!
,
May 19 2017
I hope you can see JavaScript in the attachment.
,
May 19 2017
Thank you for providing more feedback. Adding requester "hdodda@chromium.org" to the cc list and removing "Needs-Feedback" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 19 2017
hdodda@, any word that occurs just once on any page will do. reporter@, normally one wouldn't hold the F3 key, and a single key press doesn't flicker. As for current behavior, it is very convenient on pages that have aggressive background picture or color: flickering allows to locate the text easily.
,
May 23 2017
Able to reproduce on Windows-10 & 7, Ubuntu 14.04 and Mac OS 10.12 using chrome stable M58-58.0.3029.110 and latest M60-60.0.3108.0 with following steps: 1. Go to chrome://version 2. Hit F3 and type "JavaScript" (is found and highlighted) 3. Press F3 and keep pressed Bisect Information: ===================== Good build:53.0.2761.0 Bad Build :53.0.2762.0 You are probably looking for a change made after 398177 (known good), but no later than 398190 (first known bad). Change Log URL: https://chromium.googlesource.com/chromium/src/+log/0475505c4370a6186fd73ffc9c8ae07af55bf0ae..f01caa59865aec4c79d128e14f4d9fc605e02916 From the above change log suspecting below change Review URL: https://codereview.chromium.org/1959183002 paulmeyer@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thanks!
,
May 23 2017
#5, woxxom: I agree, it can be convenient. But it is obviously not intended behavior, which is rarely a good thing (it is not documented or continuously tested, and might behave inconsistently and/or change over time). In fact, sometimes, but not always, the highlight flickers on a single keypress. If someone likes this as a features, they might request it, but this bug is probably not the right place :)
,
May 24 2017
This behavior is a side effect of the way that active matches are traversed in the new multi-process find-in-page model; specifically, because of the now asynchronous coordination between the browser and render processes. When a new find next request is issued, but no more results are found in the active frame, this information is relayed via IPC to the browser process, to which it responds by reissuing the request (via IPC) to the subsequent frame, potentially in a different render process. In the case of there only being a single match on the page, the subsequent frame is actually the same frame, and the very same match will be rehighlighted as active. It is only during the time of this IPC roundtrip that this match is not active (which is why it can briefly appear yellow like other regular matches, rather than orange). That being said, I believe this behavior is harmless, and I'm glad to see that some may even consider it a feature. Overall, find-in-page is working as intended. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ligim...@chromium.org
, May 18 2017