Widget::Restore after Widget::Minimize does not restore X11 window.
Reported by
alshaba...@yandex-team.ru,
May 18 2017
|
|||
Issue description
UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 YaBrowser/17.3.1.873 (beta) Yowser/2.5 Safari/537.36
Steps to reproduce the problem:
A test in widget_interactive_uitest.cc:
```
TEST_F(WidgetTestInteractive, RestoreAfterMinimize) {
Widget* widget = CreateWidget();
ShowSync(widget);
ASSERT_FALSE(widget->IsMinimized());
widget->Minimize();
base::RunLoop().RunUntilIdle();
EXPECT_TRUE(widget->IsMinimized());
widget->Restore();
base::RunLoop().RunUntilIdle();
EXPECT_FALSE(widget->IsMinimized());
widget->CloseNow();
}
```
What is the expected behavior?
What went wrong?
The last EXPECT_FALSE fails on X11.
Did this work before? N/A
Chrome version: 56.0.2924.87 Channel: n/a
OS Version:
Flash Version:
It seems that this started to fail after https://codereview.chromium.org/2630773002/
,
May 18 2017
Can you try using WidgetActivationWaiter?
,
May 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd8019cfb439f7ebdc135820179f1cfc5c810b45 commit dd8019cfb439f7ebdc135820179f1cfc5c810b45 Author: alshabalin <alshabalin@yandex-team.ru> Date: Wed May 24 08:22:35 2017 Fix Restore after Minimize on X11. BUG= 723986 Review-Url: https://codereview.chromium.org/2891893002 Cr-Commit-Position: refs/heads/master@{#474211} [modify] https://crrev.com/dd8019cfb439f7ebdc135820179f1cfc5c810b45/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc [modify] https://crrev.com/dd8019cfb439f7ebdc135820179f1cfc5c810b45/ui/views/widget/widget_interactive_uitest.cc
,
Jul 20 2017
,
Jul 25 2017
fixed? |
|||
►
Sign in to add a comment |
|||
Comment 1 by thomasanderson@chromium.org
, May 18 2017