Headless seg faults if post data isn't in byte form |
||
Issue descriptionHeadless chrome will seg fault in GetPostData[1] if the ElementReader is not of type UploadBytesElementReader, as the parent class UploadElementReader will return nullptr. [1] https://cs.chromium.org/chromium/src/headless/public/util/generic_url_request_job.cc?rcl=88b9bc14b5d592e258623f27363d768ec25ce05b&l=274
,
May 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c72320950b6ac44b11399af2c07691e354921b2 commit 1c72320950b6ac44b11399af2c07691e354921b2 Author: irisu <irisu@chromium.org> Date: Fri May 19 00:23:49 2017 Add check for that reader is not null in GetPostData. This is necessary as the reader maybe not be an UploadBytesElementReader, but other subclasses of UploadElementReader e.g. UploadBlobElementReader. BUG= 723983 Review-Url: https://codereview.chromium.org/2886403002 Cr-Commit-Position: refs/heads/master@{#472990} [modify] https://crrev.com/1c72320950b6ac44b11399af2c07691e354921b2/headless/public/util/generic_url_request_job.cc
,
May 31 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by skyos...@chromium.org
, May 18 2017