New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 723982 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Disable video_VideoSeek.vp8.switchres on nyan devices

Project Member Reported by kcwu@chromium.org, May 18 2017

Issue description

video_VideoSeek.vp8.switchres failed due to issue 699260. Since it cannot be fixed in near future. We should disable it temporarily.

 
Cc: vsu...@chromium.org avkodipelli@chromium.org
Cc: owenlin@chromium.org kcwu@chromium.org
Labels: -Pri-3 videoshortlist Pri-2
Owner: johnylin@chromium.org
Status: Assigned (was: Untriaged)
Johny. Can you help with this?
Project Member

Comment 3 by bugdroid1@chromium.org, May 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b60a397c6b1d5c2da9aec9f56e4a1ea36f66802a

commit b60a397c6b1d5c2da9aec9f56e4a1ea36f66802a
Author: Pin-chih Lin <johnylin@google.com>
Date: Mon May 22 10:20:39 2017

video_VideoSeek: disable vp8 switchres for nyan

Add two parameters (codec, is_switchres) to run_test.
Add blacklist filter to skip the test if it matches
(board, codec, is_switchres)

Which board supports wildcards.

BUG= chromium:723982 
TEST=manual test

Change-Id: I74d3d72b96eed777ce2347c0fd662ebe07374897
Reviewed-on: https://chromium-review.googlesource.com/509668
Commit-Ready: Pin-chih Lin <johnylin@chromium.org>
Tested-by: Pin-chih Lin <johnylin@chromium.org>
Reviewed-by: Kuang-che Wu <kcwu@chromium.org>

[modify] https://crrev.com/b60a397c6b1d5c2da9aec9f56e4a1ea36f66802a/client/site_tests/video_VideoSeek/control.h264.switchres
[modify] https://crrev.com/b60a397c6b1d5c2da9aec9f56e4a1ea36f66802a/client/site_tests/video_VideoSeek/video_VideoSeek.py
[modify] https://crrev.com/b60a397c6b1d5c2da9aec9f56e4a1ea36f66802a/client/site_tests/video_VideoSeek/control.vp8
[modify] https://crrev.com/b60a397c6b1d5c2da9aec9f56e4a1ea36f66802a/client/site_tests/video_VideoSeek/control.vp9
[modify] https://crrev.com/b60a397c6b1d5c2da9aec9f56e4a1ea36f66802a/client/site_tests/video_VideoSeek/control.vp8.switchres
[modify] https://crrev.com/b60a397c6b1d5c2da9aec9f56e4a1ea36f66802a/client/site_tests/video_VideoSeek/control.h264

Comment 4 by kcwu@chromium.org, May 24 2017

This is landed in 9576.0.0 but the test is still failing after that.

  File "/usr/local/autotest/tests/video_VideoSeek/video_VideoSeek.py", line 73, in run_once
    sleep_interval=1)
  File "/usr/local/autotest/common_lib/utils.py", line 2756, in poll_for_condition
    raise exception
TestError: Seek test is stuck and timeout
https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/testDetails?milestone=60&testName=video_VideoSeek

board name of nyan devices should be "nyan_*" not "nyan-*" (e.g. nyan_big)
will make another CL for correcting this, thanks.
Project Member

Comment 6 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/3ab9c30e5c1e310901ea36998f229a83c53a39eb

commit 3ab9c30e5c1e310901ea36998f229a83c53a39eb
Author: Pin-chih Lin <johnylin@google.com>
Date: Wed May 24 09:06:32 2017

video_VideoSeek: correct nyan board name expression

Correct board name expression from "nyan-*" to "nyan_*"

BUG= chromium:723982 
TEST=manual test

Change-Id: If6cc36c8f2c643a04408641af1ad9cd47e5dd870
Reviewed-on: https://chromium-review.googlesource.com/513842
Commit-Ready: Pin-chih Lin <johnylin@chromium.org>
Tested-by: Pin-chih Lin <johnylin@chromium.org>
Reviewed-by: Kuang-che Wu <kcwu@chromium.org>

[modify] https://crrev.com/3ab9c30e5c1e310901ea36998f229a83c53a39eb/client/site_tests/video_VideoSeek/video_VideoSeek.py

TestNAError is thrown and health monitoring still shows yellow cells. Can we make it pass instead?
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/0b4e6ec29956222f7914bba76d085f5f3ad964a2

commit 0b4e6ec29956222f7914bba76d085f5f3ad964a2
Author: Pin-chih Lin <johnylin@google.com>
Date: Fri Jun 02 17:39:00 2017

video_VideoSeek: pass immediately for vp8 switchres nyan

After discussion, we return run_once immediately to make the test
skipped (and passed) instead of raising TestNAError.

BUG= chromium:723982 
TEST=manual test

Change-Id: I3851bc549af692583437bc2f5d69304d774ffa52
Reviewed-on: https://chromium-review.googlesource.com/522305
Commit-Ready: Pin-chih Lin <johnylin@chromium.org>
Tested-by: Pin-chih Lin <johnylin@chromium.org>
Reviewed-by: Kuang-che Wu <kcwu@chromium.org>

[modify] https://crrev.com/0b4e6ec29956222f7914bba76d085f5f3ad964a2/client/site_tests/video_VideoSeek/video_VideoSeek.py

Status: Started (was: Assigned)
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 6 2017

Labels: merge-merged-release-R59-9460.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/87da2c5e15d883fba54dc0bbb3c908dc3139ffb5

commit 87da2c5e15d883fba54dc0bbb3c908dc3139ffb5
Author: Pin-chih Lin <johnylin@google.com>
Date: Tue Jun 06 01:35:15 2017

video_VideoSeek: disable vp8 switchres for nyan

Add two parameters (codec, is_switchres) to run_test.
Add blacklist filter to skip the test if it matches
(board, codec, is_switchres)

Which board supports wildcards.

BUG= chromium:723982 
TEST=manual test

Change-Id: I74d3d72b96eed777ce2347c0fd662ebe07374897
Reviewed-on: https://chromium-review.googlesource.com/509668
Commit-Ready: Pin-chih Lin <johnylin@chromium.org>
Tested-by: Pin-chih Lin <johnylin@chromium.org>
Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
(cherry picked from commit b60a397c6b1d5c2da9aec9f56e4a1ea36f66802a)
Reviewed-on: https://chromium-review.googlesource.com/523904
Commit-Queue: Pin-chih Lin <johnylin@chromium.org>
Trybot-Ready: Pin-chih Lin <johnylin@chromium.org>

[modify] https://crrev.com/87da2c5e15d883fba54dc0bbb3c908dc3139ffb5/client/site_tests/video_VideoSeek/control.h264.switchres
[modify] https://crrev.com/87da2c5e15d883fba54dc0bbb3c908dc3139ffb5/client/site_tests/video_VideoSeek/video_VideoSeek.py
[modify] https://crrev.com/87da2c5e15d883fba54dc0bbb3c908dc3139ffb5/client/site_tests/video_VideoSeek/control.vp8
[modify] https://crrev.com/87da2c5e15d883fba54dc0bbb3c908dc3139ffb5/client/site_tests/video_VideoSeek/control.vp9
[modify] https://crrev.com/87da2c5e15d883fba54dc0bbb3c908dc3139ffb5/client/site_tests/video_VideoSeek/control.vp8.switchres
[modify] https://crrev.com/87da2c5e15d883fba54dc0bbb3c908dc3139ffb5/client/site_tests/video_VideoSeek/control.h264

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/49699c324407921c5362b8bb8432e404234ebf83

commit 49699c324407921c5362b8bb8432e404234ebf83
Author: Pin-chih Lin <johnylin@google.com>
Date: Tue Jun 06 01:35:18 2017

video_VideoSeek: correct nyan board name expression

Correct board name expression from "nyan-*" to "nyan_*"

BUG= chromium:723982 
TEST=manual test

Change-Id: If6cc36c8f2c643a04408641af1ad9cd47e5dd870
Reviewed-on: https://chromium-review.googlesource.com/513842
Commit-Ready: Pin-chih Lin <johnylin@chromium.org>
Tested-by: Pin-chih Lin <johnylin@chromium.org>
Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
(cherry picked from commit 3ab9c30e5c1e310901ea36998f229a83c53a39eb)
Reviewed-on: https://chromium-review.googlesource.com/523889
Commit-Queue: Pin-chih Lin <johnylin@chromium.org>
Trybot-Ready: Pin-chih Lin <johnylin@chromium.org>

[modify] https://crrev.com/49699c324407921c5362b8bb8432e404234ebf83/client/site_tests/video_VideoSeek/video_VideoSeek.py

Project Member

Comment 12 by bugdroid1@chromium.org, Jun 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c25f562a874c07ba4191b9cef4706199a19ab449

commit c25f562a874c07ba4191b9cef4706199a19ab449
Author: Pin-chih Lin <johnylin@google.com>
Date: Tue Jun 06 01:38:48 2017

video_VideoSeek: pass immediately for vp8 switchres nyan

After discussion, we return run_once immediately to make the test
skipped (and passed) instead of raising TestNAError.

BUG= chromium:723982 
TEST=manual test

Change-Id: I3851bc549af692583437bc2f5d69304d774ffa52
Reviewed-on: https://chromium-review.googlesource.com/522305
Commit-Ready: Pin-chih Lin <johnylin@chromium.org>
Tested-by: Pin-chih Lin <johnylin@chromium.org>
Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
(cherry picked from commit 0b4e6ec29956222f7914bba76d085f5f3ad964a2)
Reviewed-on: https://chromium-review.googlesource.com/523890
Commit-Queue: Pin-chih Lin <johnylin@chromium.org>
Trybot-Ready: Pin-chih Lin <johnylin@chromium.org>

[modify] https://crrev.com/c25f562a874c07ba4191b9cef4706199a19ab449/client/site_tests/video_VideoSeek/video_VideoSeek.py

Status: Fixed (was: Started)
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 8 2017

Labels: merge-merged-release-R60-9592.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/678779338870e88d3969daf64cbf3d3db858680f

commit 678779338870e88d3969daf64cbf3d3db858680f
Author: Pin-chih Lin <johnylin@google.com>
Date: Thu Jun 08 14:47:24 2017

video_VideoSeek: pass immediately for vp8 switchres nyan

After discussion, we return run_once immediately to make the test
skipped (and passed) instead of raising TestNAError.

BUG= chromium:723982 
TEST=manual test

Change-Id: I3851bc549af692583437bc2f5d69304d774ffa52
Reviewed-on: https://chromium-review.googlesource.com/522305
Commit-Ready: Pin-chih Lin <johnylin@chromium.org>
Tested-by: Pin-chih Lin <johnylin@chromium.org>
Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
(cherry picked from commit 0b4e6ec29956222f7914bba76d085f5f3ad964a2)
Reviewed-on: https://chromium-review.googlesource.com/527857
Commit-Queue: Pin-chih Lin <johnylin@chromium.org>
Trybot-Ready: Pin-chih Lin <johnylin@chromium.org>

[modify] https://crrev.com/678779338870e88d3969daf64cbf3d3db858680f/client/site_tests/video_VideoSeek/video_VideoSeek.py

Sign in to add a comment