Add presubmit warning for when DEFINE_STATIC_REF is used in a header file |
|||
Issue descriptionHeader files may be used by multiple link targets. Using DEFINE_STATIC_REF in a header can result in separate global objects where only one is intended. See issue 723295 for an example of this occurring.
,
May 18 2017
Sounds reasonable; I guess this could be implemented either as another rule in the webkitpy-linter webkitpy/style/checkers/cpp.py, or directly in third_party/WebKit/PRESUBMIT.py.
,
May 21 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 22 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by alancutter@chromium.org
, May 18 2017