New issue
Advanced search Search tips

Issue 723972 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Wrong extra directory in location line when viewing shared folder

Project Member Reported by yamaguchi@chromium.org, May 18 2017

Issue description

Chrome Version: 60.0.3103.0

Steps To Reproduce:
(1) Share a folder from another user
(2) Open the Files app.
(3) Click "Shared with me". See the shared folder appears on RHS.
(4) Double-click the shared folder on RHS to go into it.
(5) See the location line (aka. breadcrumb list at left-top of the window showing current directory hierarchy).

Expected Result:
Shared with me > The Folder's Name

Actual Result:
Shared with me > r > The Folder's Name
Clicking "r" doesn't change views.

How frequently does this problem reproduce? (Always, sometimes, hard to
 reproduce?)
Always

What is the impact to the user, and is there a workaround? If so, what is
it?
User can ignore it.

This seems to be a recent regression; not happening on 58.0.3029.112.
 
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3948e1ac83818850cda8a68916e90501beb785a1

commit 3948e1ac83818850cda8a68916e90501beb785a1
Author: yamaguchi <yamaguchi@chromium.org>
Date: Thu May 18 07:53:38 2017

Fix location line for shared-with-me directory

It inserted extra "r" directory when the display root full path begins with "/other".
This was a regression introduced by 2839863002.
https://codereview.chromium.org/2839863002/diff/240001/ui/file_manager/file_manager/foreground/js/ui/location_line.js

TEST=manually verified in the Files app.
BUG= 723972 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2885143010
Cr-Commit-Position: refs/heads/master@{#472728}

[modify] https://crrev.com/3948e1ac83818850cda8a68916e90501beb785a1/ui/file_manager/file_manager/foreground/js/ui/location_line.js

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
ChromeOS 9574.0.0, 60.0.3105.0

Sign in to add a comment