New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 723966 link

Starred by 1 user
Status: Fixed
Owner:
paulir...@chromium.org
Closed: Jul 2017
Cc:
nyerramilli@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[DevTools] Default focus issue is seen on 'Audits to perform' overlay.

Reported by dchau...@etouch.net, May 18 2017 
Chrome Version: 60.0.3103.0 (Official Build) (64-bit) 0d2b07cab5a9dfb8429b42ae5b8ccdfac5d56fd7-refs/heads/master@{#472587} 32/64-bit.
OS: Windows (7,8,10), Mac (10.11.6, 10.12.3), Linux (14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome, open DevTools and go to 'Audits' section.
2. Click on "+" (New audit) icon to open 'Audits to perform' overlay.
3. Now, press 'Enter' key from keyboard and observe.

Nothing happens on pressing 'Enter' key from keyboard.
Audit should run on pressing 'Enter' key i.e. default focus should be on 'Run audit' button.

This is a non regression issue, seen from M-60 series i.e. build # 60.0.3102.0

Kindly review the attached screen-cast for reference.
Actual behavior.mp4
757 KB View Download

Comment 1 by ranjitkan@chromium.org, May 19 2017

Status: Untriaged (was: Unconfirmed)
Untriaged, so that it gets addressed.

Comment 2 by kozyatinskiy@chromium.org, May 19 2017

Owner: paulir...@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2afd2acd7372a385ce3fa81b0dcc49064c93abe

commit f2afd2acd7372a385ce3fa81b0dcc49064c93abe
Author: Paul Irish <paulirish@chromium.org>
Date: Mon Jul 24 22:22:02 2017

DevTools: [Audits] Roll Lighthouse 2.3.0 w/ dense report

Also fixing: solid white background, scrolling restored,
removing unneeded call to `Input.setIgnoreInputEvents` and
'Run audit' button has autofocus.

Rolled LH commit: 924e1f11bd6b31f3a105185a8d667143770f3c65


Bug: 663085,  723966 ,  747231 
Change-Id: Id8f9c34a80fc0d251c07b9633fcd83a81cadc95c
Reviewed-on: https://chromium-review.googlesource.com/580500
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489099}
[modify] https://crrev.com/f2afd2acd7372a385ce3fa81b0dcc49064c93abe/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js
[modify] https://crrev.com/f2afd2acd7372a385ce3fa81b0dcc49064c93abe/third_party/WebKit/Source/devtools/front_end/audits2/audits2Panel.css
[modify] https://crrev.com/f2afd2acd7372a385ce3fa81b0dcc49064c93abe/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/category-renderer.js
[modify] https://crrev.com/f2afd2acd7372a385ce3fa81b0dcc49064c93abe/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/crc-details-renderer.js
[modify] https://crrev.com/f2afd2acd7372a385ce3fa81b0dcc49064c93abe/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/details-renderer.js
[modify] https://crrev.com/f2afd2acd7372a385ce3fa81b0dcc49064c93abe/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/dom.js
[modify] https://crrev.com/f2afd2acd7372a385ce3fa81b0dcc49064c93abe/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/report-renderer.js
[modify] https://crrev.com/f2afd2acd7372a385ce3fa81b0dcc49064c93abe/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/util.js
[modify] https://crrev.com/f2afd2acd7372a385ce3fa81b0dcc49064c93abe/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/report-styles.css
[modify] https://crrev.com/f2afd2acd7372a385ce3fa81b0dcc49064c93abe/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/templates.html
[modify] https://crrev.com/f2afd2acd7372a385ce3fa81b0dcc49064c93abe/third_party/WebKit/Source/devtools/front_end/audits2_worker/lighthouse/lighthouse-background.js

Comment 4 by paulir...@chromium.org, Jul 25 2017

Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 28 2017

Labels: merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04561f437bff516fee6c50db2f6c571a29efa9cb

commit 04561f437bff516fee6c50db2f6c571a29efa9cb
Author: Paul Irish <paulirish@chromium.org>
Date: Fri Jul 28 21:23:29 2017

DevTools: [Audits] Roll Lighthouse 2.3.0 w/ dense report

Also fixing: solid white background, scrolling restored,
removing unneeded call to `Input.setIgnoreInputEvents` and
'Run audit' button has autofocus.

Rolled LH commit: 924e1f11bd6b31f3a105185a8d667143770f3c65

TBR=paulirish@chromium.org

(cherry picked from commit f2afd2acd7372a385ce3fa81b0dcc49064c93abe)

Bug: 663085,  723966 ,  747231 
Change-Id: Id8f9c34a80fc0d251c07b9633fcd83a81cadc95c
Reviewed-on: https://chromium-review.googlesource.com/580500
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489099}
Reviewed-on: https://chromium-review.googlesource.com/592402
Reviewed-by: Paul Irish <paulirish@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#114}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/04561f437bff516fee6c50db2f6c571a29efa9cb/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js
[modify] https://crrev.com/04561f437bff516fee6c50db2f6c571a29efa9cb/third_party/WebKit/Source/devtools/front_end/audits2/audits2Panel.css
[modify] https://crrev.com/04561f437bff516fee6c50db2f6c571a29efa9cb/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/category-renderer.js
[modify] https://crrev.com/04561f437bff516fee6c50db2f6c571a29efa9cb/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/crc-details-renderer.js
[modify] https://crrev.com/04561f437bff516fee6c50db2f6c571a29efa9cb/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/details-renderer.js
[modify] https://crrev.com/04561f437bff516fee6c50db2f6c571a29efa9cb/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/dom.js
[modify] https://crrev.com/04561f437bff516fee6c50db2f6c571a29efa9cb/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/report-renderer.js
[modify] https://crrev.com/04561f437bff516fee6c50db2f6c571a29efa9cb/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/util.js
[modify] https://crrev.com/04561f437bff516fee6c50db2f6c571a29efa9cb/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/report-styles.css
[modify] https://crrev.com/04561f437bff516fee6c50db2f6c571a29efa9cb/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/templates.html
[modify] https://crrev.com/04561f437bff516fee6c50db2f6c571a29efa9cb/third_party/WebKit/Source/devtools/front_end/audits2_worker/lighthouse/lighthouse-background.js

Comment 6 by dchau...@etouch.net, Aug 1 2017

Labels: TE-Verified-M61 TE-Verified-61.0.3163.25
Rechecked this issue on Windows 10 and Mac 10.11.6 & Linux(14.04 LTS) OS using chrome version 61.0.3163.25 and fix is working as expected i.e. default focus seen on 'Run audit' button.

Attaching screen-cast for the same.
61.0.3163.25 _behavior.mp4
616 KB View Download
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4daa74328a267cbe6b64ee846647dce1a901430

commit e4daa74328a267cbe6b64ee846647dce1a901430
Author: Paul Irish <paulirish@chromium.org>
Date: Thu Feb 22 01:27:59 2018

DevTools: [Audits] Autofocus the primary buttons

Bug:  812584 ,  723966 
Change-Id: Id293f15f5fb556878b2ca5c7bf7d2ee82caf742a
Reviewed-on: https://chromium-review.googlesource.com/929587
Reviewed-by: Patrick Hulce <phulce@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538300}
[modify] https://crrev.com/e4daa74328a267cbe6b64ee846647dce1a901430/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Dialog.js

Comment 8 by dchau...@etouch.net, Feb 22 2018

Labels: TE-Verified-M66 TE-Verified-66.0.3352.0
Update:-
 Re-tested this issue on Windows (7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.3) and Linux(14.04 LTS) machines using latest Chrome canary build# 66.0.3352.0 and fix is working as expected.. Hence adding TE Verified labels. 

Please find the attached screen-cast for reference.

Thanks..!
Latest Canary behavior.mp4
480 KB View Download

Comment 9 by paulir...@chromium.org, Feb 22 2018 

thanks dchaubey. :)
►

Sign in to add a comment