takePhoto() fails in Mac |
||||||
Issue descriptiontakePhoto() rejects in Mac after adding support for an optional dictionary of PhotoSettings. This is because setOptions() is not implemented in Mac.
,
May 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d9d6d4fd30cc0e8840ef957dfbd7e996fe7a498 commit 8d9d6d4fd30cc0e8840ef957dfbd7e996fe7a498 Author: Miguel Casas-Sanchez <mcasas@chromium.org> Date: Fri May 19 00:36:32 2017 Image Capture Mac: make setOptions() resolve the callback with true This CL implements VideoCaptureDevice::setOptions() for Mac so that we can resolve the callback with a true value -- setPhotoOptionsCallback on ToT resolves |callback| with false if not explicitly Run() and Blink will think it has failed. Bug: 723929 Change-Id: I2c9f0ec482538f7f1c389ea4bc970552fd39e324 Reviewed-on: https://chromium-review.googlesource.com/508183 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by: Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#472994} [modify] https://crrev.com/8d9d6d4fd30cc0e8840ef957dfbd7e996fe7a498/media/capture/video/mac/video_capture_device_mac.h [modify] https://crrev.com/8d9d6d4fd30cc0e8840ef957dfbd7e996fe7a498/media/capture/video/mac/video_capture_device_mac.mm
,
May 19 2017
,
May 19 2017
,
May 20 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/347764e21457f5dfc357ec4a0fc9374b1f011d17 commit 347764e21457f5dfc357ec4a0fc9374b1f011d17 Author: mcasas <mcasas@chromium.org> Date: Sat May 20 01:16:12 2017 Image Capture Mac: make setOptions() resolve the callback with true This CL implements VideoCaptureDevice::setOptions() for Mac so that we can resolve the callback with a true value -- setPhotoOptionsCallback on ToT resolves |callback| with false if not explicitly Run() and Blink will think it has failed. Bug: 723929 Change-Id: I2c9f0ec482538f7f1c389ea4bc970552fd39e324 Reviewed-on: https://chromium-review.googlesource.com/508183 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by: Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#472994} (cherry picked from commit 8d9d6d4fd30cc0e8840ef957dfbd7e996fe7a498) NOTRY=True NOPRESUBMIT=True TBR=scheib@chromium.org Review-Url: https://codereview.chromium.org/2895013003 Cr-Commit-Position: refs/branch-heads/3071@{#641} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/347764e21457f5dfc357ec4a0fc9374b1f011d17/media/capture/video/mac/video_capture_device_mac.h [modify] https://crrev.com/347764e21457f5dfc357ec4a0fc9374b1f011d17/media/capture/video/mac/video_capture_device_mac.mm
,
May 20 2017
,
May 20 2017
Verified on Canary with https://yellowdoge.github.io/demos/imagecapture.html |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by mcasas@chromium.org
, May 18 2017