New issue
Advanced search Search tips

Issue 723928 link

Starred by 2 users
Status: Available
Owner: ----
Cc:
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

ntp4: break circular dependencies and typecheck with v2 closure GYP

Project Member Reported by dbeam@chromium.org, May 18 2017 
right now there's a bunch of circular deps in the chrome/browser/resources/ntp4 code.  everything basically depends on everything and the object model is a little muddy and held together by functions() {} running in a later scope (as far as I can tell).

Comment 1 by dbeam@chromium.org, May 18 2017

Blocking: 585553

Comment 2 by santosru...@gmail.com, May 18 2017 

585553 blicking
Project Member

Comment 3 by bugdroid1@chromium.org, May 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4cc35c01c052ed93ac46727085ef52d98a0217f

commit e4cc35c01c052ed93ac46727085ef52d98a0217f
Author: dbeam <dbeam@chromium.org>
Date: Thu May 18 17:26:36 2017

ntp4: Fix some closure compiler annotations in apps_page.js

R=dpapad@chromium.org
BUG=723928
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2891873002
Cr-Commit-Position: refs/heads/master@{#472857}

[modify] https://crrev.com/e4cc35c01c052ed93ac46727085ef52d98a0217f/chrome/browser/resources/ntp4/apps_page.js

Comment 4 by dbeam@chromium.org, May 19 2017

Blocking: -585553

Comment 5 by dbeam@chromium.org, Jul 6 2017

Owner: ----
I'm no longer working on Chrome, and unlikely to fix any bug I'm currently assigned.

So this bug doesn't languish, I'm unassigning myself.

Comment 6 by benhenry@google.com, Jan 11

Status: Available (was: Started)
This issue has been marked as started, but has no owner. Making available.
►

Sign in to add a comment