New issue
Advanced search Search tips

Issue 723908 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 729092



Sign in to add a comment

Experiment with different placeholder text in omnibox

Project Member Reported by k...@chromium.org, May 17 2017

Issue description

We would like to increase engagement with the Clank omnibox by using more understandable placeholder strings on Clank (the string you see when there is no text in the omnibox). Therefore, we would like to run an experiment for different omnibox placeholder text.

Design Doc: https://docs.google.com/document/d/1C9_d-BDBfvJNn6XqtSzeEEq2sfamDmAkKgjuRaVWxxM/edit?hl=en#
 

Comment 1 by k...@chromium.org, May 17 2017

Cc: edwardjung@chromium.org
Do we need a chrome flag here to enable users to set the hint text?

Comment 3 by k...@chromium.org, May 24 2017

I'm guessing no. As long as testers can test it somehow, e.g. through command line flags.
Project Member

Comment 4 by bugdroid1@chromium.org, May 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea3fb69a9bb9ce86d98fa6f9cabe6084a739fdf5

commit ea3fb69a9bb9ce86d98fa6f9cabe6084a739fdf5
Author: huayinz <huayinz@chromium.org>
Date: Wed May 31 21:21:02 2017

[Android] Omnibox Placeholder Experiment

Added:
+ Variations of hint text in omnibox placeholder for the experiment
+ Chrome flags to change hint text for testing purpose
+ Field trial testing config for testing purpose
+ The hint text change will show up on the second launch after
  flag is set.

BUG= 723908 

Review-Url: https://codereview.chromium.org/2903293002
Cr-Commit-Position: refs/heads/master@{#476027}

[modify] https://crrev.com/ea3fb69a9bb9ce86d98fa6f9cabe6084a739fdf5/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
[add] https://crrev.com/ea3fb69a9bb9ce86d98fa6f9cabe6084a739fdf5/chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxPlaceholderFieldTrial.java
[modify] https://crrev.com/ea3fb69a9bb9ce86d98fa6f9cabe6084a739fdf5/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java
[modify] https://crrev.com/ea3fb69a9bb9ce86d98fa6f9cabe6084a739fdf5/chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java
[modify] https://crrev.com/ea3fb69a9bb9ce86d98fa6f9cabe6084a739fdf5/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java
[modify] https://crrev.com/ea3fb69a9bb9ce86d98fa6f9cabe6084a739fdf5/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/ea3fb69a9bb9ce86d98fa6f9cabe6084a739fdf5/chrome/android/java_sources.gni
[modify] https://crrev.com/ea3fb69a9bb9ce86d98fa6f9cabe6084a739fdf5/testing/variations/fieldtrial_testing_config.json

Blocking: 729092
Status: Fixed (was: Assigned)

Comment 7 by k...@chromium.org, Jun 19 2017

Quick question - can we make this string server-configurable? So we can experiment with new strings via Finch that aren't hardcoded into the client?
We can make this possible by overriding strings in Finch config. The only problem is Finch config does not fully handle localization. If we want the experiment to cover locales with different languages, we need to make a config file for each language and put the translated strings in each config file.

Comment 9 by k...@chromium.org, Jun 22 2017

Yep that's fine. We can run experiments with specific locales vs. all locales.
Issue 664355 has been merged into this issue.

Sign in to add a comment