New issue
Advanced search Search tips

Issue 723889 link

Starred by 1 user
Status: Fixed
Owner:
braveyao@chromium.org
Closed: May 2017
Cc:
guidou@chromium.org
niklase@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Presenters mouse cursor is in the wrong place on viewers screen

Project Member Reported by braveyao@chromium.org, May 17 2017 
Chrome Version: Any
OS: Ubuntu 14.04

What steps will reproduce the problem?
(1) On Linux, open Chrome to start a presentation.
(2) From picker, choose Application Window and then choose a non-chrome window to share
(3) Move the cursor in that window

What is the expected result?
the viewer can see the cursor in the right position.

What happens instead?
The mouse cursor is offset below and slightly right of where it actually should be on the screen

Please use labels and text to provide additional information.
This only happens to window sharing on Linux with non-chrome windows.

Comment 1 by braveyao@chromium.org, May 17 2017 

The reason is the window capture and cursor capture may happen in different windows, possible parent and child. See https://cs.chromium.org/chromium/src/third_party/webrtc/modules/desktop_capture/mouse_cursor_monitor_x11.cc?q=mouse_cursor_monitor_x+package:%5Echromium$&l=27 for more details.
The parent window may have decorations added by window manager. So the relative position of cursor got in this window may have an offset to its child window. 

As to the fix, we need to compensate the offset between those two windows.

Comment 2 by braveyao@chromium.org, May 17 2017 

Forgot to say, the Chrome window seems having no those decorations, so this issue can only be reproduced with non-Chrome windows sharing.

Comment 3 by braveyao@chromium.org, May 23 2017 

The CL has landed, https://codereview.webrtc.org/2889063002/, (the bug number wasn't correctly set in the cl so there is no update here...). 
Waiting for the rolling into chromium.

Comment 4 by braveyao@chromium.org, May 26 2017

Status: Fixed (was: Started)
The fix has been rolled into chromium on May23 and verified with chromium build 60.0.3112.0

Comment 5 by anatolid@chromium.org, May 31 2017

Labels: M-60
►

Sign in to add a comment