New issue
Advanced search Search tips

Issue 723888 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Placeholder content is incorrect color in incongnito

Project Member Reported by mdjones@chromium.org, May 17 2017

Issue description

When focusing the omnibox from the peeking state of Chrome Home in incognito, the placeholder content is the incorrect color. The placeholder color should match the tab model.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f00f909143bb444b0fc887fff764f4e760a0147e

commit f00f909143bb444b0fc887fff764f4e760a0147e
Author: mdjones <mdjones@chromium.org>
Date: Wed May 24 02:39:15 2017

[Home] Fix placeholder color for incognito

Expanding the bottom sheet from the peeking state now uses the
correct incognito default color. This change also introduces the
concept of bottom sheet content having a normal or incognito theme
which aids in making the transitions smooth.

BUG= 723888 

Review-Url: https://codereview.chromium.org/2892673002
Cr-Commit-Position: refs/heads/master@{#474133}

[modify] https://crrev.com/f00f909143bb444b0fc887fff764f4e760a0147e/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkSheetContent.java
[modify] https://crrev.com/f00f909143bb444b0fc887fff764f4e760a0147e/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSheetContent.java
[modify] https://crrev.com/f00f909143bb444b0fc887fff764f4e760a0147e/chrome/android/java/src/org/chromium/chrome/browser/history/HistorySheetContent.java
[modify] https://crrev.com/f00f909143bb444b0fc887fff764f4e760a0147e/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoBottomSheetContent.java
[modify] https://crrev.com/f00f909143bb444b0fc887fff764f4e760a0147e/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java
[modify] https://crrev.com/f00f909143bb444b0fc887fff764f4e760a0147e/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java
[modify] https://crrev.com/f00f909143bb444b0fc887fff764f4e760a0147e/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetContentController.java
[modify] https://crrev.com/f00f909143bb444b0fc887fff764f4e760a0147e/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/PlaceholderSheetContent.java

Status: Fixed (was: Assigned)

Sign in to add a comment