Replace with mojo apis. See ash/README.md and go/mustash.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/793f7de295bb2f89de7797d323f25b5bb7bf9300 commit 793f7de295bb2f89de7797d323f25b5bb7bf9300 Author: Evan Stade <estade@chromium.org> Date: Wed Aug 23 01:40:14 2017 Whittle away some Chrome dependencies on ui/message_center Bug: 723882 Change-Id: I47cbb2d5fefeed201117d0f8ccc1d85f67de43da Reviewed-on: https://chromium-review.googlesource.com/615881 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#496549} [modify] https://crrev.com/793f7de295bb2f89de7797d323f25b5bb7bf9300/chrome/browser/BUILD.gn [modify] https://crrev.com/793f7de295bb2f89de7797d323f25b5bb7bf9300/chrome/browser/download/notification/download_item_notification.cc [modify] https://crrev.com/793f7de295bb2f89de7797d323f25b5bb7bf9300/chrome/browser/notifications/message_center_notification_manager.cc [modify] https://crrev.com/793f7de295bb2f89de7797d323f25b5bb7bf9300/chrome/browser/notifications/message_center_notifications_unittest.cc [modify] https://crrev.com/793f7de295bb2f89de7797d323f25b5bb7bf9300/ui/message_center/fake_message_center.cc [modify] https://crrev.com/793f7de295bb2f89de7797d323f25b5bb7bf9300/ui/message_center/views/desktop_popup_alignment_delegate.cc [modify] https://crrev.com/793f7de295bb2f89de7797d323f25b5bb7bf9300/ui/message_center/views/message_center_view.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f14512471775f0b89c2e51389316cf52d24761dc commit f14512471775f0b89c2e51389316cf52d24761dc Author: Evan Stade <estade@chromium.org> Date: Tue Sep 05 17:44:00 2017 Remove support for side-by-side chromeos multi profile mode. The flag to enable this was removed 3.5 years ago in dc6938a6f60389c30d4 so it should be safe to remove the code as well. This will allow us to move MultiUserNotificationBlockerChromeOS into ash/ in a follow up. Bug: 336916 , 723882 , 578868 Change-Id: I2f8d506e7a5793a82daaa27e4c56a325fb8f45cf Reviewed-on: https://chromium-review.googlesource.com/629979 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Stefan Kuhne <skuhne@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#499669} [modify] https://crrev.com/f14512471775f0b89c2e51389316cf52d24761dc/chrome/browser/chromeos/extensions/wallpaper_private_api_unittest.cc [modify] https://crrev.com/f14512471775f0b89c2e51389316cf52d24761dc/chrome/browser/notifications/message_center_notifications_unittest.cc [modify] https://crrev.com/f14512471775f0b89c2e51389316cf52d24761dc/chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc [modify] https://crrev.com/f14512471775f0b89c2e51389316cf52d24761dc/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc [modify] https://crrev.com/f14512471775f0b89c2e51389316cf52d24761dc/chrome/browser/ui/ash/launcher/browser_status_monitor.cc [modify] https://crrev.com/f14512471775f0b89c2e51389316cf52d24761dc/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc [modify] https://crrev.com/f14512471775f0b89c2e51389316cf52d24761dc/chrome/browser/ui/ash/launcher/chrome_launcher_controller_util.cc [modify] https://crrev.com/f14512471775f0b89c2e51389316cf52d24761dc/chrome/browser/ui/ash/launcher/chrome_launcher_controller_util.h [modify] https://crrev.com/f14512471775f0b89c2e51389316cf52d24761dc/chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.cc [modify] https://crrev.com/f14512471775f0b89c2e51389316cf52d24761dc/chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.h [modify] https://crrev.com/f14512471775f0b89c2e51389316cf52d24761dc/chrome/browser/ui/ash/multi_user/multi_user_context_menu_chromeos_unittest.cc [modify] https://crrev.com/f14512471775f0b89c2e51389316cf52d24761dc/chrome/browser/ui/ash/multi_user/multi_user_notification_blocker_chromeos.cc [modify] https://crrev.com/f14512471775f0b89c2e51389316cf52d24761dc/chrome/browser/ui/ash/multi_user/multi_user_notification_blocker_chromeos.h [modify] https://crrev.com/f14512471775f0b89c2e51389316cf52d24761dc/chrome/browser/ui/ash/multi_user/multi_user_notification_blocker_chromeos_unittest.cc [modify] https://crrev.com/f14512471775f0b89c2e51389316cf52d24761dc/chrome/browser/ui/ash/multi_user/multi_user_util.cc [modify] https://crrev.com/f14512471775f0b89c2e51389316cf52d24761dc/chrome/browser/ui/ash/multi_user/multi_user_window_manager.cc [modify] https://crrev.com/f14512471775f0b89c2e51389316cf52d24761dc/chrome/browser/ui/ash/multi_user/multi_user_window_manager.h [modify] https://crrev.com/f14512471775f0b89c2e51389316cf52d24761dc/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc [modify] https://crrev.com/f14512471775f0b89c2e51389316cf52d24761dc/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc [modify] https://crrev.com/f14512471775f0b89c2e51389316cf52d24761dc/chrome/browser/ui/ash/multi_user/multi_user_window_manager_test.cc [modify] https://crrev.com/f14512471775f0b89c2e51389316cf52d24761dc/chrome/browser/ui/browser_finder_chromeos_unittest.cc [modify] https://crrev.com/f14512471775f0b89c2e51389316cf52d24761dc/chrome/browser/ui/views/frame/system_menu_model_builder.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/424c9a889abc8e93c9058734d1a2f3d17b217b50 commit 424c9a889abc8e93c9058734d1a2f3d17b217b50 Author: Evan Stade <estade@chromium.org> Date: Tue Feb 06 18:13:02 2018 Remove some more dependencies on MessageCenter. Various changes: - Start adding DEPS exceptions in preparation for banning ui/message_center dependencies more broadly. - Remove a file full of constants in ui/message_center - delete some unnecessary message_center.h includes - remove some message center color constants in favor of direct use of Label::SetAutoColorReadabilityEnabled. BUG= 783018 , 723882 TBR=rogerta@chromium.org Change-Id: Ia7b9332d575a77581691f65f98c945754820c212 Reviewed-on: https://chromium-review.googlesource.com/879501 Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#534721} [modify] https://crrev.com/424c9a889abc8e93c9058734d1a2f3d17b217b50/ash/sidebar/sidebar_widget.cc [modify] https://crrev.com/424c9a889abc8e93c9058734d1a2f3d17b217b50/chrome/browser/background/background_mode_manager_unittest.cc [modify] https://crrev.com/424c9a889abc8e93c9058734d1a2f3d17b217b50/chrome/browser/chromeos/display/display_prefs_unittest.cc [modify] https://crrev.com/424c9a889abc8e93c9058734d1a2f3d17b217b50/chrome/browser/chromeos/system/automatic_reboot_manager_unittest.cc [add] https://crrev.com/424c9a889abc8e93c9058734d1a2f3d17b217b50/chrome/browser/extensions/api/autotest_private/DEPS [modify] https://crrev.com/424c9a889abc8e93c9058734d1a2f3d17b217b50/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc [modify] https://crrev.com/424c9a889abc8e93c9058734d1a2f3d17b217b50/chrome/browser/extensions/extension_storage_monitor.cc [modify] https://crrev.com/424c9a889abc8e93c9058734d1a2f3d17b217b50/chrome/browser/notifications/DEPS [modify] https://crrev.com/424c9a889abc8e93c9058734d1a2f3d17b217b50/chrome/browser/signin/easy_unlock_notification_controller_chromeos.cc [modify] https://crrev.com/424c9a889abc8e93c9058734d1a2f3d17b217b50/chrome/browser/ui/ash/chrome_screenshot_grabber_browsertest.cc [add] https://crrev.com/424c9a889abc8e93c9058734d1a2f3d17b217b50/chrome/browser/ui/views/message_center/DEPS [modify] https://crrev.com/424c9a889abc8e93c9058734d1a2f3d17b217b50/ui/message_center/BUILD.gn [modify] https://crrev.com/424c9a889abc8e93c9058734d1a2f3d17b217b50/ui/message_center/views/bounded_label.cc [modify] https://crrev.com/424c9a889abc8e93c9058734d1a2f3d17b217b50/ui/message_center/views/bounded_label.h [delete] https://crrev.com/8b3db9c5ab3b8a659cb93caed0e276d7452d4ddc/ui/message_center/views/constants.h [modify] https://crrev.com/424c9a889abc8e93c9058734d1a2f3d17b217b50/ui/message_center/views/notification_button.cc [modify] https://crrev.com/424c9a889abc8e93c9058734d1a2f3d17b217b50/ui/message_center/views/notification_view.cc [modify] https://crrev.com/424c9a889abc8e93c9058734d1a2f3d17b217b50/ui/message_center/views/notification_view_md.cc [modify] https://crrev.com/424c9a889abc8e93c9058734d1a2f3d17b217b50/ui/message_center/views/notification_view_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88326687e1b5ecef1f6e9ac90ad371756427fc93 commit 88326687e1b5ecef1f6e9ac90ad371756427fc93 Author: Daniel Bratell <bratell@opera.com> Date: Tue Feb 06 21:16:23 2018 Jumbo build fix: Use unique names of constants in message_center A recent CL got rid of the shared constants and instead copied them to relevant files. To work in jumbo builds they must then have unique names. (The alternative to find a shared location for the constants seems not applicable in this case) Bug: 783018 , 723882 Change-Id: I8e64dcf56bfe74d30279549291e89bdec80bc3d2 Reviewed-on: https://chromium-review.googlesource.com/905304 Commit-Queue: Daniel Bratell <bratell@opera.com> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#534793} [modify] https://crrev.com/88326687e1b5ecef1f6e9ac90ad371756427fc93/ui/message_center/views/notification_view_md.cc
Comment 1 by est...@chromium.org
, Aug 11 2017Status: Started (was: Untriaged)