New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 723876 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 678705



Sign in to add a comment

mash: Remove ash::Shell access from chrome/browser/lifetime

Project Member Reported by jamescook@chromium.org, May 17 2017

Issue description

See ash/README.md and go/mustash

 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2b582d8591c2baab7ddbc78469eb365481bb392

commit d2b582d8591c2baab7ddbc78469eb365481bb392
Author: Elliot Glaysher <erg@chromium.org>
Date: Thu Sep 21 19:27:34 2017

Audit usage of //ash/ in //chrome/browser/lifetime/

Bug:  723876 
Change-Id: I7219e887970abf5aed950a4d20affc2b7ad660f5
Reviewed-on: https://chromium-review.googlesource.com/675669
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Elliot Glaysher <erg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503531}
[modify] https://crrev.com/d2b582d8591c2baab7ddbc78469eb365481bb392/chrome/browser/lifetime/DEPS
[modify] https://crrev.com/d2b582d8591c2baab7ddbc78469eb365481bb392/chrome/browser/lifetime/application_lifetime_aura.cc

Components: -Internals>MUS Internals>Services>WindowService
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb348dbff39e0e2a91757b21c7f7efdece7cc658

commit eb348dbff39e0e2a91757b21c7f7efdece7cc658
Author: Qiang Xu <warx@google.com>
Date: Wed Mar 28 15:47:20 2018

remove an include rule in c/b/p/DEPS

changes:
This file is now ash/public/cpp/accessibility_types.h, which chrome can
depend on.

Bug:  723876 
Test: trybots
Change-Id: I565443e82e58bc1b761ecf2831385941f0385ce3
Reviewed-on: https://chromium-review.googlesource.com/982977
Commit-Queue: Qiang Xu <warx@google.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546497}
[modify] https://crrev.com/eb348dbff39e0e2a91757b21c7f7efdece7cc658/chrome/browser/policy/DEPS

Comment 4 by est...@chromium.org, Jun 28 2018

Owner: e...@chromium.org
Status: Fixed (was: Untriaged)

Sign in to add a comment