New issue
Advanced search Search tips

Issue 723875 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

Handle regression ranges, test results, and findit results on grouped alerts

Project Member Reported by zhangtiff@chromium.org, May 17 2017

Issue description

It looks like these particular parts of Sheriff-o-Matic aren't really things that Chrome OS uses, so we'll have to get these to work with alert grouping. 

Simplest would be to just make these things show up on the individual subalerts in a group. It gets a little trickier if we want to display these things in the merged view of all the alerts in a group. 
 
For CrOS I tried to have a merged view which showed things in common, and then allow the sub-alert select and see all the details.
Owner: ----
Status: Available (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/ef0b4313e7518f16c109b08b2a674fa81669974f

commit ef0b4313e7518f16c109b08b2a674fa81669974f
Author: Stephen Martinis <martiniss@chromium.org>
Date: Mon Oct 30 20:28:41 2017

SOM: Fix reason merging

There's a small logic bug in the code, where if a group has a reason,
and there's nothing wrong with merging in the new alert's reason, it
won't actually merge the reason. This CL fixes this, and adds a test.

Bug:  723875 
Change-Id: Iff771b5fe6800f3aca1b7fcfbbe9926d89d96f5b
Reviewed-on: https://chromium-review.googlesource.com/730882
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/ef0b4313e7518f16c109b08b2a674fa81669974f/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-view/som-alert-view.js
[modify] https://crrev.com/ef0b4313e7518f16c109b08b2a674fa81669974f/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-alert-view-test.html

Status: Fixed (was: Available)

Sign in to add a comment