New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 723870 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

apache2 command used for restart is throwing errors due to lack of suders

Project Member Reported by haddowk@chromium.org, May 17 2017

Issue description


cl/502188 causes issue becuase apache2 can not be run with sudo from the apache user.

Correct issues with suders, and add stop and start to possible commands apache can run as sudo

 
There are other permission problem associated with gsutil not being owned by moblab, however apache code now attempts to update the directory if necessary but does not have the permission to do so.
Project Member

Comment 2 by bugdroid1@chromium.org, May 23 2017

Labels: merge-merged-release-R59-9460.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/2d2f410c1da2dd6bbb0cb4342cffb06cdebf2828

commit 2d2f410c1da2dd6bbb0cb4342cffb06cdebf2828
Author: Keith Haddow <haddowk@chromium.org>
Date: Tue May 23 17:06:23 2017

[moblab] add apache2, start and stop commands to suders

the apache users needs to be able to restart apache, as well as
start and stop upstart jobs, add these commands into the suders.d

BUG= chromium:723870 
TEST=manual testing on local moblab

Change-Id: I127ac18310a9ceb04a211e488aee30688a63748a
Reviewed-on: https://chromium-review.googlesource.com/510742
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Jinsong Mu <jinsong@google.com>
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>

[rename] https://crrev.com/2d2f410c1da2dd6bbb0cb4342cffb06cdebf2828/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-0.0.5-r57.ebuild
[modify] https://crrev.com/2d2f410c1da2dd6bbb0cb4342cffb06cdebf2828/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-0.0.5.ebuild

Project Member

Comment 3 by bugdroid1@chromium.org, May 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/a9c46946185f6366d56525b7e6aafb3da6692c05

commit a9c46946185f6366d56525b7e6aafb3da6692c05
Author: Keith Haddow <haddowk@chromium.org>
Date: Tue May 23 23:56:55 2017

[moblab] add apache2, start and stop commands to suders

the apache users needs to be able to restart apache, as well as
start and stop upstart jobs, add these commands into the suders.d

BUG= chromium:723870 
TEST=manual testing on local moblab

Change-Id: I127ac18310a9ceb04a211e488aee30688a63748a
Reviewed-on: https://chromium-review.googlesource.com/510014
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Jinsong Mu <jinsong@google.com>
Reviewed-by: Keith Haddow <haddowk@chromium.org>

[rename] https://crrev.com/a9c46946185f6366d56525b7e6aafb3da6692c05/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-0.0.5-r57.ebuild
[modify] https://crrev.com/a9c46946185f6366d56525b7e6aafb3da6692c05/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-0.0.5.ebuild

Project Member

Comment 4 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/793ac9ebaf745e067a2b39b3fb69fea2449f4188

commit 793ac9ebaf745e067a2b39b3fb69fea2449f4188
Author: Keith Haddow <haddowk@chromium.org>
Date: Wed May 24 18:22:44 2017

[moblab] Set CROS_CACHEDIR for apache service.

The apache user can not currently share the same gsutil installation
as moblab user since the gs code attempts to update the installation
and the directory is owned by one or the other users.

Ideally the gs code would be updated to handle this case well, however
for now make a separate gsutil install just for apache, it is only 20M
of disk space.

BUG= chromium:723870 
TEST=manually on moblab
CQ-DEPEND=CL:510014

Change-Id: I1c29a5471136694c628dbe15ddce6782ac25773d
Reviewed-on: https://chromium-review.googlesource.com/513370
Reviewed-by: Michael Tang <ntang@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>

[rename] https://crrev.com/793ac9ebaf745e067a2b39b3fb69fea2449f4188/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-0.0.5-r58.ebuild
[modify] https://crrev.com/793ac9ebaf745e067a2b39b3fb69fea2449f4188/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-apache-init.conf
[modify] https://crrev.com/793ac9ebaf745e067a2b39b3fb69fea2449f4188/project-moblab/chromeos-base/chromeos-bsp-moblab/files/moblab-apache-settings.conf

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/53c5b0e498efff1d76d4fcf5ac3042c75b4867df

commit 53c5b0e498efff1d76d4fcf5ac3042c75b4867df
Author: Keith Haddow <haddowk@chromium.org>
Date: Fri Jun 02 06:49:31 2017

[moblab] Set CROS_CACHEDIR for apache service.

The apache user can not currently share the same gsutil installation
as moblab user since the gs code attempts to update the installation
and the directory is owned by one or the other users.

Ideally the gs code would be updated to handle this case well, however
for now make a separate gsutil install just for apache, it is only 20M
of disk space.

BUG= chromium:723870 
TEST=manually on moblab
CQ-DEPEND=CL:510014

Change-Id: I1c29a5471136694c628dbe15ddce6782ac25773d
Reviewed-on: https://chromium-review.googlesource.com/513395
Commit-Ready: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Jinsong Mu <jinsong@google.com>
Reviewed-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/53c5b0e498efff1d76d4fcf5ac3042c75b4867df/project-moblab/chromeos-base/chromeos-bsp-moblab/files/moblab-apache-settings.conf
[modify] https://crrev.com/53c5b0e498efff1d76d4fcf5ac3042c75b4867df/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-apache-init.conf
[rename] https://crrev.com/53c5b0e498efff1d76d4fcf5ac3042c75b4867df/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-0.0.5-r59.ebuild

Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 5 2017

Labels: merge-merged-release-R60-9592.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b505b4dc40027f9d38e7edc7463fe7af4deba417

commit b505b4dc40027f9d38e7edc7463fe7af4deba417
Author: Keith Haddow <haddowk@chromium.org>
Date: Mon Jun 05 22:07:57 2017

[moblab] Only download gsutil when needed.

Originally I got the gsutil cmd every time the module loaded, this
turns out to be a bad thing since it is possible to be doing an
expensive operation early on in the boot up process.

TEST=local moblab, unittests
BUG= chromium:723870 

Change-Id: Ia7460051dde8baa21f1e8a4b22b5e5ae040efd05
Reviewed-on: https://chromium-review.googlesource.com/523679
Reviewed-by: Jinsong Mu <jinsong@google.com>
Tested-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/b505b4dc40027f9d38e7edc7463fe7af4deba417/frontend/afe/moblab_rpc_interface_unittest.py
[modify] https://crrev.com/b505b4dc40027f9d38e7edc7463fe7af4deba417/frontend/afe/moblab_rpc_interface.py

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b505b4dc40027f9d38e7edc7463fe7af4deba417

commit b505b4dc40027f9d38e7edc7463fe7af4deba417
Author: Keith Haddow <haddowk@chromium.org>
Date: Mon Jun 05 22:07:57 2017

[moblab] Only download gsutil when needed.

Originally I got the gsutil cmd every time the module loaded, this
turns out to be a bad thing since it is possible to be doing an
expensive operation early on in the boot up process.

TEST=local moblab, unittests
BUG= chromium:723870 

Change-Id: Ia7460051dde8baa21f1e8a4b22b5e5ae040efd05
Reviewed-on: https://chromium-review.googlesource.com/523679
Reviewed-by: Jinsong Mu <jinsong@google.com>
Tested-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/b505b4dc40027f9d38e7edc7463fe7af4deba417/frontend/afe/moblab_rpc_interface_unittest.py
[modify] https://crrev.com/b505b4dc40027f9d38e7edc7463fe7af4deba417/frontend/afe/moblab_rpc_interface.py

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c5ec0606943d3aa1232adf5e75eaebbdd2f48952

commit c5ec0606943d3aa1232adf5e75eaebbdd2f48952
Author: Keith Haddow <haddowk@chromium.org>
Date: Mon Jun 05 23:39:50 2017

[moblab] Only download gsutil when needed.

Originally I got the gsutil cmd every time the module loaded, this
turns out to be a bad thing since it is possible to be doing an
expensive operation early on in the boot up process.

TEST=local moblab, unittests
BUG= chromium:723870 

Change-Id: Ia7460051dde8baa21f1e8a4b22b5e5ae040efd05
Reviewed-on: https://chromium-review.googlesource.com/521739
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Jinsong Mu <jinsong@google.com>
Reviewed-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/c5ec0606943d3aa1232adf5e75eaebbdd2f48952/frontend/afe/moblab_rpc_interface_unittest.py
[modify] https://crrev.com/c5ec0606943d3aa1232adf5e75eaebbdd2f48952/frontend/afe/moblab_rpc_interface.py

Labels: VerifyIn-61
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/7a455a7255718cd23d851152b036d31b19095363

commit 7a455a7255718cd23d851152b036d31b19095363
Author: Keith Haddow <haddowk@chromium.org>
Date: Mon Aug 07 22:16:52 2017

[moblab] Set CROS_CACHEDIR for apache service.

The apache user can not currently share the same gsutil installation
as moblab user since the gs code attempts to update the installation
and the directory is owned by one or the other users.

Ideally the gs code would be updated to handle this case well, however
for now make a separate gsutil install just for apache, it is only 20M
of disk space.

BUG= chromium:723870 
TEST=manually on moblab
CQ-DEPEND=CL:510014

Change-Id: I1c29a5471136694c628dbe15ddce6782ac25773d
Reviewed-on: https://chromium-review.googlesource.com/513395
Commit-Ready: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Jinsong Mu <jinsong@google.com>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
(cherry picked from commit 53c5b0e498efff1d76d4fcf5ac3042c75b4867df)
Reviewed-on: https://chromium-review.googlesource.com/604482
Commit-Queue: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/7a455a7255718cd23d851152b036d31b19095363/project-moblab/chromeos-base/chromeos-bsp-moblab/files/moblab-apache-settings.conf
[modify] https://crrev.com/7a455a7255718cd23d851152b036d31b19095363/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-apache-init.conf
[add] https://crrev.com/7a455a7255718cd23d851152b036d31b19095363/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-0.0.5-r59.ebuild

Comment 12 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment