New issue
Advanced search Search tips

Issue 723859 link

Starred by 1 user
Status: Verified
Owner:
hongchan@chromium.org
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Fix layout tests that are broken after applying layout-test-tidy

Project Member Reported by hongchan@chromium.org, May 17 2017 
Fix the following layout tests before landing a complete cleanup CL with layout-test-tidy.

* Duplicate variables after `let` conversion or incorrect JS syntax after applying clang-format.
webaudio/Analyser/realtimeanalyser-downmix.html
webaudio/Analyser/realtimeanalyser-freq-data-smoothing.html
webaudio/Analyser/realtimeanalyser-freq-data.html
webaudio/AudioBufferSource/audiobuffersource-ended.html
webaudio/AudioBufferSource/audiobuffersource-playbackrate-zero.html
webaudio/AudioParam/audioparam-setValueCurve-exceptions.html
webaudio/BiquadFilter/biquad-automation.html
webaudio/BiquadFilter/biquad-getFrequencyResponse.html
webaudio/Oscillator/oscillator-ended.html
webaudio/internals/scriptprocessornode-premature-death.html

* Diff failure after clang-format.
webaudio/unit-tests/audit-failures.html
webaudio/unit-tests/audit.html

* Console message line number change.
webaudio/AudioParam/audioparam-nominal-range.html
webaudio/BiquadFilter/biquadfilternode-basic.html
webaudio/IIRFilter/iir-unstable.html
webaudio/dom-exceptions.html
Project Member

Comment 1 by bugdroid1@chromium.org, May 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc41c678cbc49da1c37df906a14d22c938c06e38

commit cc41c678cbc49da1c37df906a14d22c938c06e38
Author: hongchan <hongchan@chromium.org>
Date: Fri May 19 17:55:04 2017

Fix layout tests to prevent errors from layout-test-tidy

Some layout tests were failing after application of layout-test-tidy
because of duplicate variables and missing semicolon. Fix them
before tidying the code.

BUG= 723859 

Review-Url: https://codereview.chromium.org/2892803002
Cr-Commit-Position: refs/heads/master@{#473240}

[modify] https://crrev.com/cc41c678cbc49da1c37df906a14d22c938c06e38/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-downmix.html
[modify] https://crrev.com/cc41c678cbc49da1c37df906a14d22c938c06e38/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-freq-data-smoothing.html
[modify] https://crrev.com/cc41c678cbc49da1c37df906a14d22c938c06e38/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-freq-data.html
[modify] https://crrev.com/cc41c678cbc49da1c37df906a14d22c938c06e38/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-ended.html
[modify] https://crrev.com/cc41c678cbc49da1c37df906a14d22c938c06e38/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate-zero.html
[modify] https://crrev.com/cc41c678cbc49da1c37df906a14d22c938c06e38/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-exceptions-expected.txt
[modify] https://crrev.com/cc41c678cbc49da1c37df906a14d22c938c06e38/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-exceptions.html
[modify] https://crrev.com/cc41c678cbc49da1c37df906a14d22c938c06e38/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-getFrequencyResponse.html
[modify] https://crrev.com/cc41c678cbc49da1c37df906a14d22c938c06e38/third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-ended.html
[modify] https://crrev.com/cc41c678cbc49da1c37df906a14d22c938c06e38/third_party/WebKit/LayoutTests/webaudio/internals/scriptprocessornode-premature-death.html
Project Member

Comment 2 by bugdroid1@chromium.org, May 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c70cb011c5f14f5752b0cbc0ea37344f1eb67641

commit c70cb011c5f14f5752b0cbc0ea37344f1eb67641
Author: hongchan <hongchan@chromium.org>
Date: Mon May 22 19:38:48 2017

Add missing semicolons in biquad-automation.html

This adds missing semicolons after the function declaration, in order to
prevent the test failure after the application of clang-format.

BUG= 723859 

Review-Url: https://codereview.chromium.org/2900813002
Cr-Commit-Position: refs/heads/master@{#473657}

[modify] https://crrev.com/c70cb011c5f14f5752b0cbc0ea37344f1eb67641/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-automation.html
Project Member

Comment 3 by bugdroid1@chromium.org, May 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c70cb011c5f14f5752b0cbc0ea37344f1eb67641

commit c70cb011c5f14f5752b0cbc0ea37344f1eb67641
Author: hongchan <hongchan@chromium.org>
Date: Mon May 22 19:38:48 2017

Add missing semicolons in biquad-automation.html

This adds missing semicolons after the function declaration, in order to
prevent the test failure after the application of clang-format.

BUG= 723859 

Review-Url: https://codereview.chromium.org/2900813002
Cr-Commit-Position: refs/heads/master@{#473657}

[modify] https://crrev.com/c70cb011c5f14f5752b0cbc0ea37344f1eb67641/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-automation.html

Comment 4 by hongchan@chromium.org, May 22 2017

Status: Verified (was: Started)
►

Sign in to add a comment