Separator lines shouldn't be shown on hover |
||||
Issue descriptionChrome Version: 60.0.3102.0 OS: Desktop URLs (if applicable) : What steps will reproduce the problem? 1. Start a PaymentRequest 2. Hover one of the rows What is the expected result? Separator lines shouldn't be visible. What happens instead of that? They are. Please provide any additional information below. Attach a screenshot if possible. UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3088.3 Safari/537.36
,
May 18 2017
We draw those as bottom borders for each row. Does the border for the row above need to be hidden as well? That's harder to implement, only hiding the bottom border will be easy.
,
May 18 2017
+Bruno to answer #2 since I don't know if you get email notifications as the OP without being CC'd.
,
May 18 2017
Ideally both, but just the bottom one for now seems fine. Thanks!
,
May 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c705be48a99fc38fd0144481ad11ca305ba0005a commit c705be48a99fc38fd0144481ad11ca305ba0005a Author: Anthony Vallee-Dubois <anthonyvd@chromium.org> Date: Fri May 19 00:07:29 2017 [Web Payments] Hide the bottom separator when the row is active. Bug: 723851 Change-Id: I0b69171a0348b04a82823af68fa9548395f5c126 Reviewed-on: https://chromium-review.googlesource.com/508224 Commit-Queue: Anthony Vallee-Dubois <anthonyvd@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#472982} [modify] https://crrev.com/c705be48a99fc38fd0144481ad11ca305ba0005a/chrome/browser/ui/views/payments/payment_request_row_view.cc [modify] https://crrev.com/c705be48a99fc38fd0144481ad11ca305ba0005a/chrome/browser/ui/views/payments/payment_request_row_view.h
,
May 19 2017
,
Jun 27 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by nyerramilli@chromium.org
, May 18 2017