New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 723847 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----


Previous locations:
gerrit:6240


Sign in to add a comment

Trybot status colors are not very accessible

Project Member Reported by delph...@chromium.org, May 17 2017

Issue description

As someone with color blindness, the "earthy" yellow running color doesn't contrast well with the passed green color.

Could you make the colors configurable?
 

Comment 1 by wyatta@google.com, May 17 2017

Cc: aga...@chromium.org

Comment 2 by wyatta@google.com, May 17 2017

Project: chromium
Moved issue gerrit:6240 to now be  issue chromium:723847 .

Comment 3 by aga...@chromium.org, May 17 2017

Components:
We can't make the colors configurable; the trybots are handled by a plugin which has no access to user-specific configuration. Or we could, but it would require spinning up a whole separate appengine app / database to support just that plugin.

We've already added icons (dots, check marks, xes) to the trybot display representing the various states, and aria labels for screen readers. I'm open to suggestions for colors that would be more distinguishable for you, but configurability is pretty far out of scope for us :(

Comment 4 by aga...@chromium.org, May 17 2017

Cc: -aga...@chromium.org andyb...@chromium.org
Components: Infra>Codereview>Gerrit
Labels: Milestone-Afterglow Proj-Gerrit-Migration
Owner: aga...@chromium.org
Status: Started (was: New)
Anyway I've tried to use the Material guidelines to pick higher-contrast colors here: https://chromium-review.googlesource.com/c/508053/
Project Member

Comment 5 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/gerrit-plugins/buildbucket/+/c3e29a10774490f526136d86f900811796f0bd41

commit c3e29a10774490f526136d86f900811796f0bd41
Author: Aaron Gable <agable@chromium.org>
Date: Wed May 17 22:36:07 2017

Use purer Material colors for buildbucket plugin

Bug:  723847 
Change-Id: Icb1f01c6005dd4af5597bee9103c7331d747f74c
Reviewed-on: https://chromium-review.googlesource.com/508053
Reviewed-by: Andrew Bonventre <andybons@chromium.org>

[modify] https://crrev.com/c3e29a10774490f526136d86f900811796f0bd41/src/main/resources/static/cr-buildbucket-view.html

Those colors are much better (at least for me!).

Comment 7 by aga...@chromium.org, May 18 2017

Status: Fixed (was: Started)
The change has been imported and will be deployed this week or next. Marking this bug fixed.

Sign in to add a comment