New issue
Advanced search Search tips

Issue 723844 link

Starred by 1 user
Status: Fixed
Owner:
parastoog@chromium.org
Closed: May 2017
Cc:
rbasuvula@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Task



Sign in to add a comment

Check for the timeout WHILE loading the subkeys

Project Member Reported by parastoog@google.com, May 17 2017 
The timeout is checked in the AddressEditor.

The code needs refactoring: the subkey request process needs to move out of the PersonalDataManagerAndroid.

Not enough unit tests.

Comment 1 Deleted

Comment 2 by rbasuvula@chromium.org, May 18 2017

Cc: rbasuvula@chromium.org
 Issue 723843  has been merged into this issue.

Comment 3 by rbasuvula@chromium.org, May 18 2017

Labels: Needs-Feedback
@Reporter: Thanks for filing the issue. Could you please provide the sample steps of the issue which would help us to triage the issue further from TE end.

Thank You!

Comment 4 Deleted

Comment 5 Deleted

Comment 6 Deleted

Comment 7 Deleted

Project Member

Comment 8 by bugdroid1@chromium.org, May 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbe49a4a05a04c51bc6ac3be5765c59740029192

commit fbe49a4a05a04c51bc6ac3be5765c59740029192
Author: parastoog <parastoog@google.com>
Date: Wed May 24 23:14:08 2017

Code refactoring:

For the sake of modularity, removes the subkey request procedure
from PersonalDataManagerAndroid to the new class SubKeyRequester, only
leaves the interface in the PersonalDataManagerAndroid.

Adds a timeout parameter to the SubKeyRequester so that the
requester will always receive a response before the time limit.
Therefore, timeout checking is removed from the AddressEditor
(except for the tests).

Adds unit tests.

BUG= 723844 

Review-Url: https://codereview.chromium.org/2879853003
Cr-Commit-Position: refs/heads/master@{#474467}

[modify] https://crrev.com/fbe49a4a05a04c51bc6ac3be5765c59740029192/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
[modify] https://crrev.com/fbe49a4a05a04c51bc6ac3be5765c59740029192/chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java
[modify] https://crrev.com/fbe49a4a05a04c51bc6ac3be5765c59740029192/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java
[modify] https://crrev.com/fbe49a4a05a04c51bc6ac3be5765c59740029192/chrome/browser/autofill/android/personal_data_manager_android.cc
[modify] https://crrev.com/fbe49a4a05a04c51bc6ac3be5765c59740029192/chrome/browser/autofill/android/personal_data_manager_android.h
[modify] https://crrev.com/fbe49a4a05a04c51bc6ac3be5765c59740029192/components/payments/core/BUILD.gn
[add] https://crrev.com/fbe49a4a05a04c51bc6ac3be5765c59740029192/components/payments/core/subkey_requester.cc
[add] https://crrev.com/fbe49a4a05a04c51bc6ac3be5765c59740029192/components/payments/core/subkey_requester.h
[add] https://crrev.com/fbe49a4a05a04c51bc6ac3be5765c59740029192/components/payments/core/subkey_requester_unittest.cc

Comment 9 by parastoog@chromium.org, May 25 2017

Status: Fixed (was: Started)
►

Sign in to add a comment