New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 723841 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

script-module-load-incomplete-no-crash failing

Project Member Reported by dmazz...@chromium.org, May 17 2017

Issue description

http/tests/dom/script-module-load-incomplete-no-crash.html

Failure reason failing on 2 builders

Builders failed on: 
- WebKit Linux Trusty (dbg): 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29
- WebKit Mac10.11 (dbg): 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29



 
Crashes:

crash log for renderer (pid <unknown>):
STDOUT: <empty>
STDERR: [8889:775:0517/082800.410646:584640306704:FATAL:ModuleMap.cpp(99)] Check failed: !is_fetching_. 
STDERR: 0   libbase.dylib                       0x000000011b7937ee base::debug::StackTrace::StackTrace(unsigned long) + 174
STDERR: 1   libbase.dylib                       0x000000011b79388d base::debug::StackTrace::StackTrace(unsigned long) + 29
STDERR: 2   libbase.dylib                       0x000000011b791d1c base::debug::StackTrace::StackTrace() + 28
STDERR: 3   libbase.dylib                       0x000000011b830b7f logging::LogMessage::~LogMessage() + 479
STDERR: 4   libbase.dylib                       0x000000011b82e4f5 logging::LogMessage::~LogMessage() + 21
STDERR: 5   libblink_core.dylib                 0x0000000127b166ce blink::ModuleMap::Entry::GetModuleScript() const + 190
STDERR: 6   libblink_core.dylib                 0x0000000127b17269 blink::ModuleMap::GetFetchedModuleScript(blink::KURL const&) const + 281
STDERR: 7   libblink_core.dylib                 0x0000000127b1044c blink::ModulatorImpl::GetFetchedModuleScript(blink::KURL const&) + 44
STDERR: 8   libblink_core.dylib                 0x0000000128ba49aa blink::ModuleTreeLinker::UninstantiatedInclusiveDescendants() + 1226
STDERR: 9   libblink_core.dylib                 0x0000000128ba3b41 blink::ModuleTreeLinker::Instantiate() + 849
STDERR: 10  libblink_core.dylib                 0x0000000128ba4434 blink::ModuleTreeLinker::NotifyOneDescendantFinished(blink::ModuleTreeLinker::DescendantLoad) + 1188
STDERR: 11  libblink_core.dylib                 0x0000000128ba3f60 blink::ModuleTreeLinker::DependencyModuleClient::NotifyModuleTreeLoadFinished(blink::ModuleScript*) + 64
STDERR: 12  libblink_core.dylib                 0x0000000128ba26ba blink::ModuleTreeLinker::AdvanceState(blink::ModuleTreeLinker::State) + 2090
STDERR: 13  libblink_core.dylib                 0x0000000128ba3773 blink::ModuleTreeLinker::NotifyModuleLoadFinished(blink::ModuleScript*) + 243
STDERR: 14  libblink_core.dylib                 0x0000000127b1aaaa void base::internal::FunctorTraits<void (blink::SingleModuleClient::*)(blink::ModuleScript*), void>::Invoke<blink::Persistent<blink::SingleModuleClient> const&, blink::Persistent<blink::ModuleScript> const&>(void (blink::SingleModuleClient::*)(blink::ModuleScript*), blink::Persistent<blink::SingleModuleClient> const&&&, blink::Persistent<blink::ModuleScript> const&&&) + 170
STDERR: 15  libblink_core.dylib                 0x0000000127b1a98f void base::internal::InvokeHelper<false, void>::MakeItSo<void (blink::SingleModuleClient::* const&)(blink::ModuleScript*), blink::Persistent<blink::SingleModuleClient> const&, blink::Persistent<blink::ModuleScript> const&>(void (blink::SingleModuleClient::* const&&&)(blink::ModuleScript*), blink::Persistent<blink::SingleModuleClient> const&&&, blink::Persistent<blink::ModuleScript> const&&&) + 95
STDERR: 16  libblink_core.dylib                 0x0000000127b1a91d void base::internal::Invoker<base::internal::BindState<void (blink::SingleModuleClient::*)(blink::ModuleScript*), blink::Persistent<blink::SingleModuleClient>, blink::Persistent<blink::ModuleScript> >, void ()>::RunImpl<void (blink::SingleModuleClient::* const&)(blink::ModuleScript*), std::__1::tuple<blink::Persistent<blink::SingleModuleClient>, blink::Persistent<blink::ModuleScript> > const&, 0ul, 1ul>(void (blink::SingleModuleClient::* const&&&)(blink::ModuleScript*), std::__1::tuple<blink::Persistent<blink::SingleModuleClient>, blink::Persistent<blink::ModuleScript> > const&&&, base::IndexSequence<0ul, 1ul>) + 125
STDERR: 17  libblink_core.dylib                 0x0000000127b1a82c base::internal::Invoker<base::internal::BindState<void (blink::SingleModuleClient::*)(blink::ModuleScript*), blink::Persistent<blink::SingleModuleClient>, blink::Persistent<blink::ModuleScript> >, void ()>::Run(base::internal::BindStateBase*) + 44
STDERR: 18  libbase.dylib                       0x000000011b73136f base::Callback<void (), (base::internal::CopyMode)0, (base::internal::RepeatMode)0>::Run() + 95
STDERR: 19  libbase.dylib                       0x000000011b795d30 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 1024
STDERR: 20  libblink_platform.dylib             0x000000012e88acf2 blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue(blink::scheduler::internal::WorkQueue*, bool, blink::scheduler::LazyNow, base::TimeTicks*) + 2162
STDERR: 21  libblink_platform.dylib             0x000000012e884f05 blink::scheduler::TaskQueueManager::DoWork(bool) + 2085
STDERR: 22  libblink_platform.dylib             0x000000012e89446f void base::internal::FunctorTraits<void (blink::scheduler::TaskQueueManager::*)(bool), void>::Invoke<base::WeakPtr<blink::scheduler::TaskQueueManager> const&, bool const&>(void (blink::scheduler::TaskQueueManager::*)(bool), base::WeakPtr<blink::scheduler::TaskQueueManager> const&&&, bool const&&&) + 159
STDERR: 23  libblink_platform.dylib             0x000000012e894365 void base::internal::InvokeHelper<true, void>::MakeItSo<void (blink::scheduler::TaskQueueManager::* const&)(bool), base::WeakPtr<blink::scheduler::TaskQueueManager> const&, bool const&>(void (blink::scheduler::TaskQueueManager::* const&&&)(bool), base::WeakPtr<blink::scheduler::TaskQueueManager> const&&&, bool const&&&) + 117
STDERR: 24  libblink_platform.dylib             0x000000012e8942dd void base::internal::Invoker<base::internal::BindState<void (blink::scheduler::TaskQueueManager::*)(bool), base::WeakPtr<blink::scheduler::TaskQueueManager>, bool>, void ()>::RunImpl<void (blink::scheduler::TaskQueueManager::* const&)(bool), std::__1::tuple<base::WeakPtr<blink::scheduler::TaskQueueManager>, bool> const&, 0ul, 1ul>(void (blink::scheduler::TaskQueueManager::* const&&&)(bool), std::__1::tuple<base::WeakPtr<blink::scheduler::TaskQueueManager>, bool> const&&&, base::IndexSequence<0ul, 1ul>) + 125
STDERR: 25  libblink_platform.dylib             0x000000012e8941ec base::internal::Invoker<base::internal::BindState<void (blink::scheduler::TaskQueueManager::*)(bool), base::WeakPtr<blink::scheduler::TaskQueueManager>, bool>, void ()>::Run(base::internal::BindStateBase*) + 44
STDERR: 26  libbase.dylib                       0x000000011b73136f base::Callback<void (), (base::internal::CopyMode)0, (base::internal::RepeatMode)0>::Run() + 95
STDERR: 27  libbase.dylib                       0x000000011b795d30 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 1024
STDERR: 28  libbase.dylib                       0x000000011b887fbe base::MessageLoop::RunTask(base::PendingTask*) + 894
STDERR: 29  libbase.dylib                       0x000000011b888510 base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) + 64
STDERR: 30  libbase.dylib                       0x000000011b888c5c base::MessageLoop::DoWork() + 668
STDERR: 31  libbase.dylib                       0x000000011b898cf8 base::MessagePumpCFRunLoopBase::RunWork() + 104
STDERR: 32  libbase.dylib                       0x000000011b898c7c ___ZN4base24MessagePumpCFRunLoopBase13RunWorkSourceEPv_block_invoke + 28
STDERR: 33  libbase.dylib                       0x000000011b838eda base::mac::CallWithEHFrame(void () block_pointer) + 10
STDERR: 34  libbase.dylib                       0x000000011b8981e5 base::MessagePumpCFRunLoopBase::RunWorkSource(void*) + 101
STDERR: 35  CoreFoundation                      0x00007fff976115c1 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
STDERR: 36  CoreFoundation                      0x00007fff9760341c __CFRunLoopDoSources0 + 556
STDERR: 37  CoreFoundation                      0x00007fff9760293f __CFRunLoopRun + 927
STDERR: 38  CoreFoundation                      0x00007fff97602338 CFRunLoopRunSpecific + 296
STDERR: 39  Foundation                          0x00007fff8b526e61 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 270
STDERR: 40  libbase.dylib                       0x000000011b8997f9 base::MessagePumpNSRunLoop::DoRun(base::MessagePump::Delegate*) + 137
STDERR: 41  libbase.dylib                       0x000000011b898a3a base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 122
STDERR: 42  libbase.dylib                       0x000000011b887a55 base::MessageLoop::RunHandler() + 453
STDERR: 43  libbase.dylib                       0x000000011b976dbb base::RunLoop::Run() + 267
STDERR: 44  libcontent.dylib                    0x0000000112aed4f5 content::RendererMain(content::MainFunctionParams const&) + 3525
STDERR: 45  libcontent.dylib                    0x0000000113102f75 content::RunNamedProcessTypeMain(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, content::MainFunctionParams const&, content::ContentMainDelegate*) + 581
STDERR: 46  libcontent.dylib                    0x0000000113104a42 content::ContentMainRunnerImpl::Run() + 1938
STDERR: 47  libcontent.dylib                    0x00000001131015fd content::ContentServiceManagerMainDelegate::RunEmbedderProcess() + 61
STDERR: 48  libembedder.dylib                   0x0000000137bfb674 service_manager::Main(service_manager::MainParams const&) + 1892
STDERR: 49  libcontent.dylib                    0x0000000113102ce9 content::ContentMain(content::ContentMainParams const&) + 89
STDERR: 50  Content Shell Framework             0x000000010cec1400 ContentMain + 80
STDERR: 51  Content Shell Helper                0x000000010cebbf72 main + 34
STDERR: 52  libdyld.dylib                       0x00007fff961bd5ad start + 1
STDERR: 

Labels: -Sheriff-Chromium
Disabling: https://codereview.chromium.org/2888983002/

Project Member

Comment 3 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/381186a82f9809e299ae9e3ff7bcd5ebb06ca825

commit 381186a82f9809e299ae9e3ff7bcd5ebb06ca825
Author: dmazzoni <dmazzoni@chromium.org>
Date: Wed May 17 21:53:21 2017

Disable crashing test: script-module-load-incomplete-no-crash.html

BUG= 723841 
NOTRY=true
TBR=kouhei@chromium.org

Review-Url: https://codereview.chromium.org/2888983002
Cr-Commit-Position: refs/heads/master@{#472581}

[modify] https://crrev.com/381186a82f9809e299ae9e3ff7bcd5ebb06ca825/third_party/WebKit/LayoutTests/TestExpectations

The virtual/mojo-loading variety of this test is also failing on the Site Isolation Win bot: https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Win/builds/19156

That needs to be disabled as well.
Project Member

Comment 5 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bee6ae077f8d451491baa7376d576c7bd5398ff2

commit bee6ae077f8d451491baa7376d576c7bd5398ff2
Author: dmazzoni <dmazzoni@chromium.org>
Date: Wed May 17 23:38:55 2017

Disable mojo-loading variant of: script-module-load-incomplete-no-crash.html

BUG= 723841 
NOTRY=true
TBR=kouhei@chromium.org

Review-Url: https://codereview.chromium.org/2885173005
Cr-Commit-Position: refs/heads/master@{#472601}

[modify] https://crrev.com/bee6ae077f8d451491baa7376d576c7bd5398ff2/third_party/WebKit/LayoutTests/TestExpectations

Cc: jam@chromium.org clamy@chromium.org nasko@chromium.org
 Issue 724989  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, May 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb

commit db5c38ed5ffceeb949a875a17b6c3e2048b4eabb
Author: neis <neis@chromium.org>
Date: Wed May 31 02:22:16 2017

[modules] Add several new WPT tests.

BUG= 594639 , 723841 

Review-Url: https://codereview.chromium.org/2845983002
Cr-Commit-Position: refs/heads/master@{#475745}

[modify] https://crrev.com/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/bad-module-specifier.js
[add] https://crrev.com/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/compilation-error-1.html
[add] https://crrev.com/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/compilation-error-2.html
[add] https://crrev.com/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/cycle-tdz-access-a.js
[add] https://crrev.com/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/cycle-tdz-access.js
[add] https://crrev.com/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/cycle-unresolvable-a.js
[add] https://crrev.com/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/cycle-unresolvable.js
[add] https://crrev.com/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/evaluation-error-1.html
[add] https://crrev.com/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/evaluation-error-2.html
[add] https://crrev.com/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/evaluation-error-3.html
[add] https://crrev.com/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/evaluation-error-4.html
[add] https://crrev.com/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/export-something-nested.js
[add] https://crrev.com/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/export-something.js
[add] https://crrev.com/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/fetch-error-1.html
[add] https://crrev.com/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/fetch-error-2.html
[add] https://crrev.com/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/fetch-error-2.js
[add] https://crrev.com/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/import-something-namespace.js
[modify] https://crrev.com/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/instantiation-error-1.html
[add] https://crrev.com/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/instantiation-error-2.html
[add] https://crrev.com/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/instantiation-error-3.html
[add] https://crrev.com/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/late-namespace-request.html
[add] https://crrev.com/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/late-star-export-request.html
[add] https://crrev.com/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/missing-export-nested.js
[add] https://crrev.com/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/missing-export.js
[add] https://crrev.com/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/module-vs-script-1.html
[add] https://crrev.com/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/module-vs-script-2.html
[add] https://crrev.com/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/nested-missing-export.js
[add] https://crrev.com/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/nomodule-attribute.html
[add] https://crrev.com/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/single-evaluation-1.html
[add] https://crrev.com/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/single-evaluation-2.html
[add] https://crrev.com/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/specifier-error.html
[add] https://crrev.com/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/syntaxerror-nested.js
[add] https://crrev.com/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/syntaxerror.js
[add] https://crrev.com/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/this-nested.js
[add] https://crrev.com/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/this.js
[add] https://crrev.com/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/throw-nested.js
[add] https://crrev.com/db5c38ed5ffceeb949a875a17b6c3e2048b4eabb/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/throw.js

Project Member

Comment 8 by bugdroid1@chromium.org, May 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/748fee3ce72b96c1a0bdf84bb7d6bdffa592e21d

commit 748fee3ce72b96c1a0bdf84bb7d6bdffa592e21d
Author: Georg Neis <neis@chromium.org>
Date: Wed May 31 06:04:13 2017

[LayoutTests] Re-enable script-module-load-incomplete-no-crash.html after fix.

R=kouhei@chromium.org

Bug:  723841 
Change-Id: I1a87c594c90ecec6388122cf3796931b3cc4fa7e
Reviewed-on: https://chromium-review.googlesource.com/518018
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475820}
[modify] https://crrev.com/748fee3ce72b96c1a0bdf84bb7d6bdffa592e21d/third_party/WebKit/LayoutTests/TestExpectations

Comment 9 by neis@chromium.org, May 31 2017

Status: Fixed (was: Assigned)

Sign in to add a comment