OfflineAudioContext should create it's thread when rendering is started, not when the object is created |
|||
Issue descriptionCurrently when an OfflineAudioContext is created, it creates a new thread which will run the context. However, it would seem to be better if this thread were created when startRendering() were called because that's then the thread would be used to run the graph
,
May 19 2017
,
May 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d697f84c040b2cf41e6d1f90a7b123c496bd836 commit 6d697f84c040b2cf41e6d1f90a7b123c496bd836 Author: hongchan <hongchan@chromium.org> Date: Thu May 25 00:39:54 2017 Lazy initialization of the rendering thread in OfflineAudioContext This CL changes the timing of thread initialization in OfflineAudioDestinationNode after starting the actual rendering. This prevents out-of-threads situation from happening particularly when user creates thousands of OfflineAudioContexts upfront. BUG= 723838 , 716800 TEST=LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-thread-creation.html Review-Url: https://codereview.chromium.org/2889393003 Cr-Commit-Position: refs/heads/master@{#474494} [add] https://crrev.com/6d697f84c040b2cf41e6d1f90a7b123c496bd836/third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-thread-smoke-test.html [modify] https://crrev.com/6d697f84c040b2cf41e6d1f90a7b123c496bd836/third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.cpp [modify] https://crrev.com/6d697f84c040b2cf41e6d1f90a7b123c496bd836/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp [modify] https://crrev.com/6d697f84c040b2cf41e6d1f90a7b123c496bd836/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.h
,
May 25 2017
Fixing this actually fixed another thread-related issue: crbug.com/535132 |
|||
►
Sign in to add a comment |
|||
Comment 1 by hongchan@chromium.org
, May 19 2017Status: Assigned (was: Available)