New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 723835 link

Starred by 1 user
Status: Archived
Owner:
khmel@chromium.org
Closed: May 2017
Cc:
█ gkihumba@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

arc: Implement retry logic for transient errors in auth context preparation.

Project Member Reported by khmel@chromium.org, May 17 2017 
Some user feedbacks has information that "Server communication error" happened due transient error. These errors can be retried. 

https://feedback.corp.google.com/product/208/neutron?lView=rd&lRSort=1&lROrder=2&lRFilter=1&lReportSearch=google%20play&lReport=60640316310

Inner bug: b/38390321
Project Member

Comment 1 by bugdroid1@chromium.org, May 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f3598e45c88e71ece4efc04e044aa1759c82cf9

commit 6f3598e45c88e71ece4efc04e044aa1759c82cf9
Author: khmel <khmel@chromium.org>
Date: Wed May 17 23:56:24 2017

arc: Implement retry logic for transient errors

BUG= 723835 
TEST=Manually, emulated different errors and confirmed that opt in
     flow worked as expected.

Review-Url: https://codereview.chromium.org/2887093003
Cr-Commit-Position: refs/heads/master@{#472606}

[modify] https://crrev.com/6f3598e45c88e71ece4efc04e044aa1759c82cf9/chrome/browser/chromeos/arc/arc_auth_context.cc
[modify] https://crrev.com/6f3598e45c88e71ece4efc04e044aa1759c82cf9/chrome/browser/chromeos/arc/arc_auth_context.h

Comment 2 by khmel@chromium.org, May 18 2017

Cc: gkihumba@chromium.org
Labels: Merge-Request-59

Comment 3 by gkihumba@google.com, May 18 2017

Labels: Merge-Approved-59
Project Member

Comment 4 by sheriffbot@chromium.org, May 18 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, May 19 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62a8cc8f4b943991e8365424d415ffe64a530220

commit 62a8cc8f4b943991e8365424d415ffe64a530220
Author: khmel <khmel@chromium.org>
Date: Fri May 19 00:10:56 2017

[Merge M59] arg: Implement retry logic for transient errors

BUG= 723835 
TEST=Manually, emulated different errors and confirmed that opt in
     flow worked as expected.
TBR=xiyuan@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2887093003
Cr-Original-Commit-Position: refs/heads/master@{#472606}
Review-Url: https://codereview.chromium.org/2896513002
Cr-Commit-Position: refs/branch-heads/3071@{#624}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/62a8cc8f4b943991e8365424d415ffe64a530220/chrome/browser/chromeos/arc/arc_auth_context.cc
[modify] https://crrev.com/62a8cc8f4b943991e8365424d415ffe64a530220/chrome/browser/chromeos/arc/arc_auth_context.h

Comment 6 by khmel@chromium.org, May 19 2017

Status: Fixed (was: Started)

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment