mushrome: WindowTreeClient check failure on shutdown |
|||||
Issue descriptionThis might be a dupe but I can't find it. Chrome ToT r472478, both on device and Linux desktop. Run with --mus. On device, "stop ui" and look at /var/log/ui/ui.LATEST On desktop, hit system tray -> Sign out. [4888:4888:0517/134956.683117:FATAL:window_tree_client.cc(265)] Check failed: windows_.empty(). #0 0x7f005628162c base::debug::StackTrace::StackTrace() #1 0x7f005629676e logging::LogMessage::~LogMessage() #2 0x7f00573865b1 aura::WindowTreeClient::~WindowTreeClient() #3 0x7f005738690e aura::WindowTreeClient::~WindowTreeClient() #4 0x7f00555102fb ash::mus::WindowManager::~WindowManager() #5 0x7f005551049e ash::mus::WindowManager::~WindowManager() #6 0x7f00584214a5 AshInit::~AshInit() #7 0x7f005826bd5c ChromeBrowserMainExtraPartsAsh::PostMainMessageLoopRun() #8 0x7f0055f03b1a ChromeBrowserMainParts::PostMainMessageLoopRun() #9 0x7f00552314c6 chromeos::ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() #10 0x7f0054b58803 content::BrowserMainLoop::ShutdownThreadsAndCleanUp() #11 0x7f0054b5afa9 content::BrowserMainRunnerImpl::Shutdown() #12 0x7f0054b53cd8 content::BrowserMain() #13 0x7f0055edb0a4 content::ContentMainRunnerImpl::Run() #14 0x7f0055ef9ea9 service_manager::Main() #15 0x7f0055ed9f81 content::ContentMain() #16 0x7f005460e4e6 ChromeMain #17 0x7f0052127816 __libc_start_main #18 0x7f005460e2f9 _start
,
May 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a454ebdc53801c9241e109db01c329c7b514770 commit 2a454ebdc53801c9241e109db01c329c7b514770 Author: sky <sky@chromium.org> Date: Fri May 19 19:26:06 2017 chromeos: makes it possible for windows to outlive WindowTreeClient Because of shutdown ordering we need to make it so aura::Windows can outlive WindowTreeClient. WindowTreeClient is wired in by way of every Window having a WindowPort. For mus the WindowPort is a WindowPortMus, which has a reference to the WindowTreeClient. Rather then having a slew of null checks I went with making ~WindowTreeClient reset the WindowPorts to a no-op WindowPort during shutdown. BUG= 723825 TEST=covered by tests R=erg@chromium.org Review-Url: https://codereview.chromium.org/2897663002 Cr-Commit-Position: refs/heads/master@{#473274} [modify] https://crrev.com/2a454ebdc53801c9241e109db01c329c7b514770/ash/shell_unittest.cc [modify] https://crrev.com/2a454ebdc53801c9241e109db01c329c7b514770/ui/aura/BUILD.gn [modify] https://crrev.com/2a454ebdc53801c9241e109db01c329c7b514770/ui/aura/env.cc [modify] https://crrev.com/2a454ebdc53801c9241e109db01c329c7b514770/ui/aura/env.h [modify] https://crrev.com/2a454ebdc53801c9241e109db01c329c7b514770/ui/aura/mus/focus_synchronizer.cc [modify] https://crrev.com/2a454ebdc53801c9241e109db01c329c7b514770/ui/aura/mus/window_tree_client.cc [modify] https://crrev.com/2a454ebdc53801c9241e109db01c329c7b514770/ui/aura/mus/window_tree_client.h [modify] https://crrev.com/2a454ebdc53801c9241e109db01c329c7b514770/ui/aura/mus/window_tree_client_unittest.cc [modify] https://crrev.com/2a454ebdc53801c9241e109db01c329c7b514770/ui/aura/test/aura_test_base.cc [modify] https://crrev.com/2a454ebdc53801c9241e109db01c329c7b514770/ui/aura/test/aura_test_base.h [modify] https://crrev.com/2a454ebdc53801c9241e109db01c329c7b514770/ui/aura/test/aura_test_helper.cc [modify] https://crrev.com/2a454ebdc53801c9241e109db01c329c7b514770/ui/aura/test/aura_test_helper.h [modify] https://crrev.com/2a454ebdc53801c9241e109db01c329c7b514770/ui/aura/test/env_test_helper.h [modify] https://crrev.com/2a454ebdc53801c9241e109db01c329c7b514770/ui/aura/window.h [add] https://crrev.com/2a454ebdc53801c9241e109db01c329c7b514770/ui/aura/window_port_for_shutdown.cc [add] https://crrev.com/2a454ebdc53801c9241e109db01c329c7b514770/ui/aura/window_port_for_shutdown.h
,
May 19 2017
,
Aug 1 2017
,
Jan 22 2018
,
Feb 26 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by sky@chromium.org
, May 18 2017Labels: mustash-2