New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 723821 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----

Blocked on:
issue 767930



Sign in to add a comment

cc_perftests failing on 3 builders

Project Member Reported by martiniss@chromium.org, May 17 2017

Issue description

cc_perftests failing on 3 builders

Builders failed on: 
- Android Nexus5 Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf
- Android Nexus6 Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20Perf
- Android Nexus7v2 Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus7v2%20Perf


The error messages are not helpful. It basically says nothing. https://chromium-swarm.appspot.com/task?id=362f5b23b303ad10&refresh=10&show_raw=1 is an example.
 
Cc: enne@chromium.org
Status: Started (was: Assigned)
I suspect this is a bug in perf waterfall integration.
Owner: nedngu...@google.com
Cc: dpranke@chromium.org m...@chromium.org
Ok, so I think I may know what is going on. The fact that run_getest_perf_test pipe all the test output to a file, then read the file later is problematic as the whole thing is silent until X minutes later when the test finish.

If we are unlucky & X is big, swarming may have killed the task due to the lack of io. I will try to change it so that run_gtest_perf_test.py output both to file (for parsing) & to stdout in real time.
Project Member

Comment 4 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3648c4f352731076b62b779597e40fed8db78e6

commit c3648c4f352731076b62b779597e40fed8db78e6
Author: nednguyen <nednguyen@google.com>
Date: Fri May 19 22:54:47 2017

Update run_gtest_perf_test.py to streaming command output to stdout & log file at the same time

BUG= 723821 
TBR=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2889153007
Cr-Commit-Position: refs/heads/master@{#473376}

[modify] https://crrev.com/c3648c4f352731076b62b779597e40fed8db78e6/testing/scripts/common.py
[modify] https://crrev.com/c3648c4f352731076b62b779597e40fed8db78e6/testing/scripts/run_gtest_perf_test.py

Cc: -enne@chromium.org nednguyen@chromium.org
Owner: enne@chromium.org
Now the log actually shows what tests are failing:

C  664.742s Main  Summary
C  664.742s Main  ********************************************************************************
C  664.742s Main  [==========] 78 tests ran.
C  664.742s Main  [  PASSED  ] 72 tests.
C  664.742s Main  [  FAILED  ] 6 tests, listed below:
C  664.742s Main  [  FAILED  ] LayerTreeHostPerfTestJsonReader.HeavyPageThreaded
C  664.742s Main  [  FAILED  ] LayerTreeHostPerfTestJsonReader.TenTenSingleThread
C  664.742s Main  [  FAILED  ] LayerTreeHostPerfTestJsonReader.TenTenThreaded
C  664.742s Main  [  FAILED  ] LayerTreeHostPerfTestLeafInvalidates.TenTenThreaded
C  664.742s Main  [  FAILED  ] ScrollingLayerTreePerfTest.LongScrollablePageSingleThread
C  664.742s Main  [  FAILED  ] ScrollingLayerTreePerfTest.LongScrollablePageThreaded
C  664.742s Main  
C  664.742s Main  6 FAILED TESTS


I will disable the failing tests & reassign this bug to enne@ for reenabling them.
Project Member

Comment 6 by bugdroid1@chromium.org, May 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec4fa85245ed85e99ac411cd8272b5163c6cc0f3

commit ec4fa85245ed85e99ac411cd8272b5163c6cc0f3
Author: nednguyen <nednguyen@google.com>
Date: Mon May 22 17:31:05 2017

Disable failing tests of cc_perftest suite on Android

The timed out tests are:

LayerTreeHostPerfTestJsonReader.HeavyPageThreaded
LayerTreeHostPerfTestJsonReader.TenTenSingleThread
LayerTreeHostPerfTestJsonReader.TenTenThreaded
LayerTreeHostPerfTestLeafInvalidates.TenTenThreaded
ScrollingLayerTreePerfTest.LongScrollablePageSingleThread
ScrollingLayerTreePerfTest.LongScrollablePageThreaded

BUG= 723821 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2897963002
Cr-Commit-Position: refs/heads/master@{#473610}

[modify] https://crrev.com/ec4fa85245ed85e99ac411cd8272b5163c6cc0f3/cc/trees/layer_tree_host_perftest.cc

Comment 7 by enne@chromium.org, Sep 22 2017

Blockedon: 767930
Owner: ----
Status: Available (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87711633bd43436dea338b0869f5ab89c89d758d

commit 87711633bd43436dea338b0869f5ab89c89d758d
Author: Sadrul Habib Chowdhury <sadrul@chromium.org>
Date: Fri Apr 20 19:10:30 2018

cc_perftests: Stop running on the perf bots.

The tests have not been very useful, and has remain disabled on a
number of bots for a while. So stop running the tests on the perf
bots altogether. The tests can still be used locally to watch for
improvements/regressions for specific changes as desired/needed.

BUG= 784454 ,  721757 ,  736150 
BUG= 698831 , 792995,  723821 

Change-Id: Ifede89a3f7a87d96bbb726e0911e1df26e6f9a6b
Reviewed-on: https://chromium-review.googlesource.com/1021653
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#552422}
[modify] https://crrev.com/87711633bd43436dea338b0869f5ab89c89d758d/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/87711633bd43436dea338b0869f5ab89c89d758d/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/87711633bd43436dea338b0869f5ab89c89d758d/tools/perf/benchmark.csv
[modify] https://crrev.com/87711633bd43436dea338b0869f5ab89c89d758d/tools/perf/core/perf_data_generator.py

Owner: sadrul@chromium.org
Status: Fixed (was: Available)
Sadrul removed the benchmark on the perf waterfall

Sign in to add a comment