New issue
Advanced search Search tips

Issue 723807 link

Starred by 1 user
Status: Verified
Owner:
cmt...@chromium.org
Closed: May 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Crosperf unit test testResultOrganizer failing

Project Member Reported by manojgupta@chromium.org, May 17 2017 
RUNNING: ./results_organizer_unittest.py
F
======================================================================
FAIL: testResultOrganizer (__main__.ResultOrganizerTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "././results_organizer_unittest.py", line 148, in testResultOrganizer
    self.assertEqual(organized, result)
AssertionError: {'benchmark1': [[{'': 'PASS', 'milliseconds_1': '1', 'milliseconds_3': '9.2', 'm [truncated]... != {'benchmark1': [[{'': 'PASS', 'milliseconds_1': '1', 'milliseconds_3': '9.2', 'm [truncated]...
Diff is 3675 characters long. Set self.maxDiff to None to see it.


Appears to start at:
commit 9a47f6ba1f3f0acefec53ea6dbdd66120b10f4c6
Author:     Caroline Tice <cmtice@google.com>
AuthorDate: Thu Apr 6 14:05:40 2017 -0700
Commit:     chrome-bot <chrome-bot@chromium.org>
CommitDate: Sat Apr 8 19:40:21 2017 -0700

    [crosperf] Fix status reporting for multiple iters inside a single run.
Project Member

Comment 1 by bugdroid1@chromium.org, May 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/toolchain-utils/+/647f97831373993c1e67e8669a70e46d4c70fd4c

commit 647f97831373993c1e67e8669a70e46d4c70fd4c
Author: Caroline Tice <cmtice@google.com>
Date: Thu May 18 01:08:40 2017

Fix results_organizer_unittest.py

Now that multiple iters inside a single run all report the correct
pass/fail status, update the unittest to reflect that (is has been
broken now for about a month).

BUG= chromium:723807 
TEST=ran unittest with fix and it passes now.

Change-Id: Ie92034bbf073b73ce820f28c238f99192840197f
Reviewed-on: https://chromium-review.googlesource.com/508277
Commit-Ready: Caroline Tice <cmtice@chromium.org>
Tested-by: Caroline Tice <cmtice@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/647f97831373993c1e67e8669a70e46d4c70fd4c/crosperf/results_organizer_unittest.py

Comment 2 by cmt...@chromium.org, May 18 2017

Status: Fixed (was: Untriaged)

Comment 3 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 4 by abod...@chromium.org, Aug 3 2017

Status: Verified (was: Fixed)
Closing. Please reopen it if its not fixed. Thanks!
►

Sign in to add a comment