git cl upload consistently takes quite a while (~40s) from my Linux box on corp wired network,

The hold-up seems to be git push though:

[D2017-05-17 12:39:50,253 13133 140164720273216 subprocess2.py] git push https://chromium.googlesource.com/chromium/src.git 075172cde8283395fbfd0cd75c9ea83dde85782a:refs/for/refs/heads/master%m=cleanup,notify=NONE
...
[D2017-05-17 12:40:26,228 13133 140164720273216 subprocess2.py] git config branch.crbug723779__reject_garbage_options.gerritissue 508171


This is an example upload of a tiny patch with -vv:








mcasas@banach:/p/chromium/src crbug723779__reject_garbage_options
$ time git cl upload -t "cleanup" -vv
[D2017-05-17 12:39:40,176 13133 140164720273216 subprocess2.py] git symbolic-ref HEAD
[D2017-05-17 12:39:40,181 13133 140164720273216 subprocess2.py] git config branch.crbug723779__reject_garbage_options.git-cl-similarity
[D2017-05-17 12:39:40,186 13133 140164720273216 subprocess2.py] git symbolic-ref HEAD
[D2017-05-17 12:39:40,191 13133 140164720273216 subprocess2.py] git config --bool branch.crbug723779__reject_garbage_options.git-find-copies
Using 50% similarity for rename/copy detection. Override with --similarity.
[D2017-05-17 12:39:40,196 13133 140164720273216 subprocess2.py] git -c color.ui=never update-index --refresh -q
[D2017-05-17 12:39:40,409 13133 140164720273216 subprocess2.py] git -c color.ui=never diff-index --name-status HEAD
[D2017-05-17 12:39:40,951 13133 140164720273216 subprocess2.py] git config rietveld.autoupdate
[D2017-05-17 12:39:40,954 13133 140164720273216 git_cl.py] Failed running ['git', 'config', 'rietveld.autoupdate']
[D2017-05-17 12:39:40,955 13133 140164720273216 subprocess2.py] git rev-parse --show-cdup
[D2017-05-17 12:39:40,958 13133 140164720273216 subprocess2.py] git config rietveld.server https://codereview.chromium.org
[D2017-05-17 12:39:40,962 13133 140164720273216 subprocess2.py] git config rietveld.cc chromium-reviews@chromium.org
[D2017-05-17 12:39:40,966 13133 140164720273216 subprocess2.py] git config --unset-all rietveld.private
[D2017-05-17 12:39:40,969 13133 140164720273216 git_cl.py] Failed running ['git', 'config', '--unset-all', 'rietveld.private']
[D2017-05-17 12:39:40,969 13133 140164720273216 subprocess2.py] git config rietveld.tree-status-url http://chromium-status.appspot.com/status
[D2017-05-17 12:39:40,974 13133 140164720273216 subprocess2.py] git config rietveld.viewvc-url https://chromium.googlesource.com/chromium/src/+/
[D2017-05-17 12:39:40,977 13133 140164720273216 subprocess2.py] git config --unset-all rietveld.bug-prefix
[D2017-05-17 12:39:40,981 13133 140164720273216 git_cl.py] Failed running ['git', 'config', '--unset-all', 'rietveld.bug-prefix']
[D2017-05-17 12:39:40,981 13133 140164720273216 subprocess2.py] git config --unset-all rietveld.cpplint-regex
[D2017-05-17 12:39:40,985 13133 140164720273216 git_cl.py] Failed running ['git', 'config', '--unset-all', 'rietveld.cpplint-regex']
[D2017-05-17 12:39:40,985 13133 140164720273216 subprocess2.py] git config rietveld.cpplint-ignore-regex webkit/api/.*
[D2017-05-17 12:39:40,988 13133 140164720273216 subprocess2.py] git config rietveld.project chromium
[D2017-05-17 12:39:40,992 13133 140164720273216 subprocess2.py] git config rietveld.run-post-upload-hook True
[D2017-05-17 12:39:40,995 13133 140164720273216 subprocess2.py] git config gerrit.host
[D2017-05-17 12:39:40,997 13133 140164720273216 git_cl.py] Failed running ['git', 'config', 'gerrit.host']
[D2017-05-17 12:39:40,997 13133 140164720273216 subprocess2.py] git symbolic-ref HEAD
[D2017-05-17 12:39:41,000 13133 140164720273216 subprocess2.py] git config branch.crbug723779__reject_garbage_options.rietveldissue
[D2017-05-17 12:39:41,003 13133 140164720273216 subprocess2.py] git config branch.crbug723779__reject_garbage_options.gerritissue
[D2017-05-17 12:39:41,006 13133 140164720273216 subprocess2.py] git config branch.crbug723779__reject_garbage_options.merge
[D2017-05-17 12:39:41,009 13133 140164720273216 subprocess2.py] git config rietveld.upstream-branch
[D2017-05-17 12:39:41,014 13133 140164720273216 git_cl.py] Failed running ['git', 'config', 'rietveld.upstream-branch']
[D2017-05-17 12:39:41,014 13133 140164720273216 subprocess2.py] git branch -r
[D2017-05-17 12:39:41,139 13133 140164720273216 subprocess2.py] git rev-parse --verify refs/remotes/origin/master
[D2017-05-17 12:39:41,153 13133 140164720273216 subprocess2.py] git -c color.ui=never config --get branch.crbug723779__reject_garbage_options.base
[D2017-05-17 12:39:41,156 13133 140164720273216 subprocess2.py] git -c color.ui=never config --get branch.crbug723779__reject_garbage_options.base-upstream
[D2017-05-17 12:39:41,158 13133 140164720273216 subprocess2.py] git -c color.ui=never merge-base refs/remotes/origin/master crbug723779__reject_garbage_options
[D2017-05-17 12:39:41,171 13133 140164720273216 subprocess2.py] git config --bool gerrit.skip-ensure-authenticated
[D2017-05-17 12:39:41,174 13133 140164720273216 git_cl.py] Failed running ['git', 'config', '--bool', 'gerrit.skip-ensure-authenticated']
[D2017-05-17 12:39:41,300 13133 140164720273216 subprocess2.py] git config branch.crbug723779__reject_garbage_options.gerritserver
[D2017-05-17 12:39:41,305 13133 140164720273216 subprocess2.py] git config branch.crbug723779__reject_garbage_options.merge
[D2017-05-17 12:39:41,309 13133 140164720273216 subprocess2.py] git config rietveld.upstream-branch
[D2017-05-17 12:39:41,313 13133 140164720273216 git_cl.py] Failed running ['git', 'config', 'rietveld.upstream-branch']
[D2017-05-17 12:39:41,313 13133 140164720273216 subprocess2.py] git branch -r
[D2017-05-17 12:39:41,441 13133 140164720273216 subprocess2.py] git config remote.origin.url
[D2017-05-17 12:39:41,451 13133 140164720273216 gerrit_util.py] GET https://chromium-review.googlesource.com/a/changes/508171/detail?o=DETAILED_ACCOUNTS&o=CURRENT_REVISION&o=CURRENT_COMMIT
[D2017-05-17 12:39:41,451 13133 140164720273216 gerrit_util.py] Authorization: HIDDEN
[D2017-05-17 12:39:43,471 13133 140164720273216 gerrit_util.py] got response 200 for GET https://chromium-review.googlesource.com/a/changes/508171/detail?o=DETAILED_ACCOUNTS&o=CURRENT_REVISION&o=CURRENT_COMMIT
[D2017-05-17 12:39:43,475 13133 140164720273216 subprocess2.py] git rev-parse --verify fb11bbe1e11b29ad870bdf5a940847dda841f542
[D2017-05-17 12:39:43,489 13133 140164720273216 subprocess2.py] git merge-base fb11bbe1e11b29ad870bdf5a940847dda841f542 HEAD
[D2017-05-17 12:39:43,501 13133 140164720273216 subprocess2.py] git rev-list ^fb11bbe1e11b29ad870bdf5a940847dda841f542 HEAD
[D2017-05-17 12:39:43,513 13133 140164720273216 subprocess2.py] git config gitcl.remotebranch
[D2017-05-17 12:39:43,519 13133 140164720273216 subprocess2.py] git rev-list ^fb11bbe1e11b29ad870bdf5a940847dda841f542 refs/remotes/origin/master
[D2017-05-17 12:39:43,540 13133 140164720273216 subprocess2.py] git rev-parse --show-cdup
[D2017-05-17 12:39:43,545 13133 140164720273216 subprocess2.py] git rev-parse HEAD
[D2017-05-17 12:39:43,563 13133 140164720273216 subprocess2.py] git diff --name-status --no-renames -r fb11bbe1e11b29ad870bdf5a940847dda841f542... .;  cwd=.
[D2017-05-17 12:39:43,634 13133 140164720273216 subprocess2.py] git config branch.crbug723779__reject_garbage_options.gerritpatchset
[D2017-05-17 12:39:43,638 13133 140164720273216 subprocess2.py] git config user.email
[D2017-05-17 12:39:43,642 13133 140164720273216 presubmit_support.py] GitAffectedFile(third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints-reject.html)
[D2017-05-17 12:39:43,642 13133 140164720273216 presubmit_support.py] GitAffectedFile(third_party/WebKit/LayoutTests/imagecapture/setOptions-reject.html)
[D2017-05-17 12:39:43,642 13133 140164720273216 presubmit_support.py] GitAffectedFile(third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp)
Running presubmit upload checks ...
[D2017-05-17 12:39:43,927 13133 140164720273216 presubmit_support.py] Presubmit files: /p/chromium/src/PRESUBMIT.py,/p/chromium/src/third_party/PRESUBMIT.py,/p/chromium/src/third_party/WebKit/PRESUBMIT.py,/p/chromium/src/third_party/WebKit/LayoutTests/PRESUBMIT.py
Running /p/chromium/src/PRESUBMIT.py
[D2017-05-17 12:39:43,974 13133 140164720273216 presubmit_support.py] Running CheckChangeOnUpload in /p/chromium/src/PRESUBMIT.py
[D2017-05-17 12:39:43,976 13133 140164720273216 gerrit_util.py] GET https://chromium-review.googlesource.com/a/changes/508171/detail?o=ALL_REVISIONS&o=DETAILED_LABELS&o=ALL_COMMITS
[D2017-05-17 12:39:43,976 13133 140164720273216 gerrit_util.py] Authorization: HIDDEN
[D2017-05-17 12:39:44,371 13133 140164720273216 gerrit_util.py] got response 200 for GET https://chromium-review.googlesource.com/a/changes/508171/detail?o=ALL_REVISIONS&o=DETAILED_LABELS&o=ALL_COMMITS
[D2017-05-17 12:39:44,372 13133 140164720273216 presubmit_canned_checks.py] owner: mcasas@chromium.org; approvals given by: 
[D2017-05-17 12:39:44,506 13133 140164720273216 subprocess2.py] git diff -p --no-color --no-prefix --no-ext-diff fb11bbe1e11b29ad870bdf5a940847dda841f542...HEAD --no-renames;  cwd=/p/chromium/src
[D2017-05-17 12:39:44,585 13133 140164720273216 subprocess2.py] /usr/bin/python /p/chromium/src/tools/checkperms/checkperms.py --root /p/chromium/src --file third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints-reject.html --file third_party/WebKit/LayoutTests/imagecapture/setOptions-reject.html --file third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp
[D2017-05-17 12:39:44,625 13133 140164720273216 presubmit_support.py] LocalPaths: ['third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints-reject.html', 'third_party/WebKit/LayoutTests/imagecapture/setOptions-reject.html', 'third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp']
[D2017-05-17 12:39:44,635 13133 140164720273216 subprocess2.py] git cl format --dry-run /p/chromium/src
[D2017-05-17 12:39:45,738 13133 140164720273216 presubmit_support.py] Running CheckChangeOnUpload done.
Running /p/chromium/src/third_party/PRESUBMIT.py
[D2017-05-17 12:39:45,853 13133 140164720273216 presubmit_support.py] Running CheckChangeOnUpload in /p/chromium/src/third_party/PRESUBMIT.py
[D2017-05-17 12:39:45,854 13133 140164720273216 presubmit_support.py] Running CheckChangeOnUpload done.
Running /p/chromium/src/third_party/WebKit/PRESUBMIT.py
[D2017-05-17 12:39:46,000 13133 140164720273216 presubmit_support.py] Running CheckChangeOnUpload in /p/chromium/src/third_party/WebKit/PRESUBMIT.py
[D2017-05-17 12:39:46,000 13133 140164720273216 presubmit_canned_checks.py] owner: mcasas@chromium.org; approvals given by: 
[D2017-05-17 12:39:46,013 13133 140164720273216 subprocess2.py] /usr/bin/python /p/chromium/src/third_party/WebKit/Tools/Scripts/lint-test-expectations

[D2017-05-17 12:39:49,290 13133 140164720273216 subprocess2.py] /usr/bin/python /p/chromium/src/third_party/WebKit/Tools/Scripts/check-webkit-style --diff-files ../../third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints-reject.html ../../third_party/WebKit/LayoutTests/imagecapture/setOptions-reject.html ../../third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp
[D2017-05-17 12:39:49,807 13133 140164720273216 presubmit_support.py] Running CheckChangeOnUpload done.
Running /p/chromium/src/third_party/WebKit/LayoutTests/PRESUBMIT.py
[D2017-05-17 12:39:49,855 13133 140164720273216 presubmit_support.py] Running CheckChangeOnUpload in /p/chromium/src/third_party/WebKit/LayoutTests/PRESUBMIT.py
[D2017-05-17 12:39:49,856 13133 140164720273216 presubmit_support.py] LocalPaths: ['third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints-reject.html', 'third_party/WebKit/LayoutTests/imagecapture/setOptions-reject.html']
[D2017-05-17 12:39:49,856 13133 140164720273216 presubmit_support.py] Running CheckChangeOnUpload done.

Presubmit checks took 6.0s to calculate.

Presubmit checks passed.
[D2017-05-17 12:39:49,960 13133 140164720273216 subprocess2.py] git diff --no-ext-diff --stat -l100000 -C50 fb11bbe1e11b29ad870bdf5a940847dda841f542 HEAD
 third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints-reject.html |  2 ++
 third_party/WebKit/LayoutTests/imagecapture/setOptions-reject.html                        |  2 ++
 third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp                           | 24 ++++++++++++++----------
 3 files changed, 18 insertions(+), 10 deletions(-)
[D2017-05-17 12:39:50,040 13133 140164720273216 subprocess2.py] git config --bool gerrit.override-squash-uploads
[D2017-05-17 12:39:50,045 13133 140164720273216 git_cl.py] Failed running ['git', 'config', '--bool', 'gerrit.override-squash-uploads']
[D2017-05-17 12:39:50,045 13133 140164720273216 subprocess2.py] git config --bool gerrit.squash-uploads
[D2017-05-17 12:39:50,049 13133 140164720273216 git_cl.py] Failed running ['git', 'config', '--bool', 'gerrit.squash-uploads']
[D2017-05-17 12:39:50,049 13133 140164720273216 subprocess2.py] git config branch.crbug723779__reject_garbage_options.merge
[D2017-05-17 12:39:50,054 13133 140164720273216 subprocess2.py] git config rietveld.upstream-branch
[D2017-05-17 12:39:50,059 13133 140164720273216 git_cl.py] Failed running ['git', 'config', 'rietveld.upstream-branch']
[D2017-05-17 12:39:50,059 13133 140164720273216 subprocess2.py] git branch -r
[D2017-05-17 12:39:50,184 13133 140164720273216 subprocess2.py] git rev-parse --verify refs/remotes/origin/master
[D2017-05-17 12:39:50,194 13133 140164720273216 subprocess2.py] git -c color.ui=never config --get branch.crbug723779__reject_garbage_options.base
[D2017-05-17 12:39:50,196 13133 140164720273216 subprocess2.py] git -c color.ui=never config --get branch.crbug723779__reject_garbage_options.base-upstream
[D2017-05-17 12:39:50,200 13133 140164720273216 subprocess2.py] git -c color.ui=never merge-base refs/remotes/origin/master crbug723779__reject_garbage_options
[D2017-05-17 12:39:50,215 13133 140164720273216 subprocess2.py] git rev-parse HEAD:
[D2017-05-17 12:39:50,225 13133 140164720273216 subprocess2.py] git commit-tree c85126314ea5728a27d7c19470688e7d19f2c934 -p fb11bbe1e11b29ad870bdf5a940847dda841f542 -m ImageCapture: reject applyConstraints()/setOptions() if there isn't any supported member

This CL corrects the code so that 
 theTrack.applyConstraints({ advanced: [{blergh : 100}]});
and
 theImageCapturer.setOptions({ foofoo: 100 });
reject due to unknown dictionary members, and also adds
Layout Tests entries.

To reject, the logic in HasNonImageCaptureConstraints() is
inverted, checking for the presence of image constraints (instead
of checking for the absence of non-image constraints, which lets
garbage through).  A straightforward check is added to setOptions().

Note that WebIdl will silently drop unsupported dictionary members.

Bug:  723779 
Change-Id: I3c911ea4d319deab828c135a9f88a3d5af0b06bf
[D2017-05-17 12:39:50,236 13133 140164720273216 subprocess2.py] git rev-list fb11bbe1e11b29ad870bdf5a940847dda841f542..075172cde8283395fbfd0cd75c9ea83dde85782a
[D2017-05-17 12:39:50,249 13133 140164720273216 subprocess2.py] git config remote.origin.url
[D2017-05-17 12:39:50,253 13133 140164720273216 subprocess2.py] git push https://chromium.googlesource.com/chromium/src.git 075172cde8283395fbfd0cd75c9ea83dde85782a:refs/for/refs/heads/master%m=cleanup,notify=NONE


remote: Processing changes: updated: 1, done            
remote: (W) 075172c: commit subject >50 characters; use shorter first paragraph        
remote: (W) No changes between prior commit 4a2fcc3 and new commit 075172c        
remote: 
remote: Updated Changes:        
remote:   https://chromium-review.googlesource.com/508171 ImageCapture: reject applyConstraints()/setOptions() if there isn't any ...        
remote: 
To https://chromium.googlesource.com/a/chromium/src.git
 * [new branch]                075172cde8283395fbfd0cd75c9ea83dde85782a -> refs/for/refs/heads/master%m=cleanup,notify=NONE
[D2017-05-17 12:40:26,228 13133 140164720273216 subprocess2.py] git config branch.crbug723779__reject_garbage_options.gerritissue 508171
[D2017-05-17 12:40:26,233 13133 140164720273216 subprocess2.py] git config branch.crbug723779__reject_garbage_options.gerritserver https://chromium-review.googlesource.com
[D2017-05-17 12:40:26,237 13133 140164720273216 subprocess2.py] git config branch.crbug723779__reject_garbage_options.gerritsquashhash 075172cde8283395fbfd0cd75c9ea83dde85782a
[D2017-05-17 12:40:26,240 13133 140164720273216 subprocess2.py] git config rietveld.cc
[D2017-05-17 12:40:26,251 13133 140164720273216 gerrit_util.py] POST https://chromium-review.googlesource.com/a/changes/508171/revisions/current/review
[D2017-05-17 12:40:26,251 13133 140164720273216 gerrit_util.py] Content-Type: application/json
[D2017-05-17 12:40:26,251 13133 140164720273216 gerrit_util.py] Authorization: HIDDEN
[D2017-05-17 12:40:26,251 13133 140164720273216 gerrit_util.py] {"reviewers": [{"reviewer": "blink-reviews@chromium.org", "state": "CC", "notify": "NONE"}, {"reviewer": "chromium-reviews@chromium.org", "state": "CC", "notify": "NONE"}, {"reviewer": "haraken@chromium.org", "state": "CC", "notify": "NONE"}, {"reviewer": "mcasas+imagecapture@chromium.org", "state": "CC", "notify": "NONE"}], "notify": "NONE"}
[D2017-05-17 12:40:29,078 13133 140164720273216 gerrit_util.py] got response 200 for POST https://chromium-review.googlesource.com/a/changes/508171/revisions/current/review
[D2017-05-17 12:40:29,080 13133 140164720273216 subprocess2.py] git rev-parse HEAD
[D2017-05-17 12:40:29,097 13133 140164720273216 subprocess2.py] git symbolic-ref HEAD
[D2017-05-17 12:40:29,101 13133 140164720273216 subprocess2.py] git config branch.crbug723779__reject_garbage_options.last-upload-hash b806ba4b8a65dd4516efb839a65c6acaeee67ca4
[D2017-05-17 12:40:29,106 13133 140164720273216 subprocess2.py] git config rietveld.run-post-upload-hook
[D2017-05-17 12:40:29,115 13133 140164720273216 presubmit_support.py] Presubmit files: /p/chromium/src/PRESUBMIT.py,/p/chromium/src/third_party/PRESUBMIT.py,/p/chromium/src/third_party/WebKit/PRESUBMIT.py,/p/chromium/src/third_party/WebKit/LayoutTests/PRESUBMIT.py
Running /p/chromium/src/third_party/WebKit/LayoutTests/PRESUBMIT.py
Running /p/chromium/src/third_party/WebKit/PRESUBMIT.py
Running /p/chromium/src/third_party/PRESUBMIT.py
Running /p/chromium/src/PRESUBMIT.py


real	0m49.189s
user	0m25.624s
sys	0m8.536s