PIN warnings/errors are too aggressive |
|||
Issue descriptionRight now, we warn users about PINs not being long enough or not matching before they have finished typing. We should add a permanent message to the dialog about the minimum length. We should only show errors when the user presses the button to confirm/complete setup.
,
Jun 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/96286e92b45dcdc817f9688c5c3303883cd7d440 commit 96286e92b45dcdc817f9688c5c3303883cd7d440 Author: Sammie Quon <sammiequon@google.com> Date: Fri Jun 23 02:10:29 2017 md settings: Modify errors/warnings on setup pin keyboard dialog. Couple modifications to errors/warnings in setup pin dialog: 1) Shows min length warning right away 2) On confirming pin step, only show mismatch error when confirm button clicked 3) Min length warning becomes error once user exceeds min length, but goes back under min length threshold. Bug: 723800 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7fb9dd7f18c8555a3d247b8a2613574abe696b32 Reviewed-on: https://chromium-review.googlesource.com/540744 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#481785} [modify] https://crrev.com/96286e92b45dcdc817f9688c5c3303883cd7d440/chrome/browser/resources/settings/people_page/setup_pin_dialog.html [modify] https://crrev.com/96286e92b45dcdc817f9688c5c3303883cd7d440/chrome/browser/resources/settings/people_page/setup_pin_dialog.js [modify] https://crrev.com/96286e92b45dcdc817f9688c5c3303883cd7d440/chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js
,
Jun 23 2017
,
Jan 22 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by sammiequon@chromium.org
, Jun 19 20173.4 MB
3.4 MB View Download