New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 723799 link

Starred by 3 users
Status: Fixed
Owner:
wjmaclean@chromium.org
Closed: May 2017
Cc:
kenrb@chromium.org
wjmaclean@chromium.org
█ smokana@chromium.org
creis@chromium.org
█ msrchandra@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 470662



Sign in to add a comment

WebFrameWidgetImpl lacks the equivalent codepath to WebViewImpl::ShowContextMenu()

Project Member Reported by wjmaclean@chromium.org, May 17 2017 
Chrome Version: 60.0.3097.0 (Developer Build) (64-bit) - tip-of-tree
OS: Linux (at least)

WebViewImpl::ShowContextMenu() is used to show the touch-selection editing popup context menu, via ViewMsg_ShowContextMenu. This is sent to RenderViewImpl from the TSE QuickMenu in the browser process.

In implementing TSE for OOPIF, we need the corresponding machinery in WebFrameWidgetImpl (and we should probably convert ViewMsg_ShowContextMenu to be a FrameMsg instead).

Comment 1 by kenrb@chromium.org, May 17 2017 

It might be possible to move the WebViewImpl::ShowContextMenu code into WebFrameWidgetBase. That makes it available to both WebViewImpl and WebFrameWidgetImpl, without duplicating it.

Comment 2 by wjmaclean@chromium.org, May 18 2017

Status: Started (was: Assigned)
That would be ideal ... I'll investigate that first.

Comment 3 by wjmaclean@chromium.org, May 25 2017

Cc: msrchandra@chromium.org smokana@chromium.org wjmaclean@chromium.org
 Issue 471729  has been merged into this issue.

Comment 4 by wjmaclean@chromium.org, May 30 2017

Status: Fixed (was: Started)
►

Sign in to add a comment