Issue 723793 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	zhangtiff@chromium.org
Closed:	Jun 2017
Cc:	davidri...@chromium.org seanmccullough@chromium.org zhangtiff@chromium.org
Components:	Infra>Sheriffing>SheriffOMatic
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	----
Milestone-UX

Polish subalert selection in an alert group

Project Member Reported by zhangtiff@chromium.org, May 17 2017

Issue description

I think it might still be a good idea to change the radio buttons into something like selectable boxes (sort of like tabs but designed to look good in multiple rows). 

The alert count is currently used to display the intersection of all alerts in a group, but this is really unintuitive, so I want to adjust this as well.

Project Member

Comment 1 by bugdroid1@chromium.org, Jun 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/ab14a5bfb3513fd5416ecc31e7aec9ed35110899

commit ab14a5bfb3513fd5416ecc31e7aec9ed35110899
Author: Tiff Zhang <zhangtiff@google.com>
Date: Tue Jun 06 21:46:47 2017

SoM: Polish grouped alert view slightly.

Bug:723793

Change-Id: I3369330710a72e0b8f55f19f1f280e8504010710
Reviewed-on: https://chromium-review.googlesource.com/508041
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>
Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org>

[modify] https://crrev.com/ab14a5bfb3513fd5416ecc31e7aec9ed35110899/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-item/som-alert-item.html
[modify] https://crrev.com/ab14a5bfb3513fd5416ecc31e7aec9ed35110899/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-item/som-alert-item.js

Comment 2 by zhangtiff@chromium.org, Jun 7 2017

Status: Fixed (was: Assigned)

This is fine for now, I think.

►

Issue 723793 link

Issue metadata

Polish subalert selection in an alert group

Issue description

Comment 1 by bugdroid1@chromium.org, Jun 6 2017

Comment 1 Deleted

Comment 2 by zhangtiff@chromium.org, Jun 7 2017

Comment 2 Deleted

Sign in to add a comment