chrome --mash * Go to rot13.com * Type text - this works fine * Type enter - no carriage return inserted Enter works fine in native UI (omnibox). Enter works fine with normal chrome, and with chrome --mash.
There's a draft CL at https://codereview.chromium.org/2957173004/
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab1ba1ead2975ce4237cd8ffec8f559d223bbe1e commit ab1ba1ead2975ce4237cd8ffec8f559d223bbe1e Author: Thanh Pham <thanhph@chromium.org> Date: Thu Sep 21 21:43:04 2017 Mus+Ash: Typing enter into web text areas doesn't work. This change: - Use DispatchKeyEventPostIME() mojo in InputMethodChromeOS. - Adds ui.mojom.TextInputClient.DispatchKeyEventPostIME(). This is because InputMethodDelegate::DispatchKeyEventPostIME() isn't really *Post* IME, and calls to it are sometimes intervened with the logic in InputMethodChromeOS to provide KeyDown and KeyUp events in addition to KeyPress events to textfields. This CL calls ui.mojom.TextInputClient.DispatchKeyEventPostIME() in these cases and continues the logic after the dispatch finishes in the client side. Diagram of this CL: https://drive.google.com/open?id=0B0MnJn1TtqqtaUVOZHVCTUtlYmM Bug: 723792 Change-Id: I97efc8dca9d772eabe38f979659d392ae796b903 Reviewed-on: https://chromium-review.googlesource.com/643746 Commit-Queue: Thanh Pham <thanhph@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#503570} [modify] https://crrev.com/ab1ba1ead2975ce4237cd8ffec8f559d223bbe1e/chrome/browser/ui/views/ime_driver/input_method_bridge_chromeos.cc [modify] https://crrev.com/ab1ba1ead2975ce4237cd8ffec8f559d223bbe1e/chrome/browser/ui/views/ime_driver/input_method_bridge_chromeos_unittest.cc [modify] https://crrev.com/ab1ba1ead2975ce4237cd8ffec8f559d223bbe1e/chrome/browser/ui/views/ime_driver/remote_text_input_client.cc [modify] https://crrev.com/ab1ba1ead2975ce4237cd8ffec8f559d223bbe1e/chrome/browser/ui/views/ime_driver/remote_text_input_client.h [modify] https://crrev.com/ab1ba1ead2975ce4237cd8ffec8f559d223bbe1e/services/ui/ime/ime_unittest.cc [modify] https://crrev.com/ab1ba1ead2975ce4237cd8ffec8f559d223bbe1e/services/ui/public/interfaces/ime/ime.mojom [modify] https://crrev.com/ab1ba1ead2975ce4237cd8ffec8f559d223bbe1e/ui/aura/mus/input_method_mus.cc [modify] https://crrev.com/ab1ba1ead2975ce4237cd8ffec8f559d223bbe1e/ui/aura/mus/input_method_mus_unittest.cc [modify] https://crrev.com/ab1ba1ead2975ce4237cd8ffec8f559d223bbe1e/ui/aura/mus/text_input_client_impl.cc [modify] https://crrev.com/ab1ba1ead2975ce4237cd8ffec8f559d223bbe1e/ui/aura/mus/text_input_client_impl.h [modify] https://crrev.com/ab1ba1ead2975ce4237cd8ffec8f559d223bbe1e/ui/base/ime/input_method_auralinux.cc [modify] https://crrev.com/ab1ba1ead2975ce4237cd8ffec8f559d223bbe1e/ui/base/ime/input_method_base.cc [modify] https://crrev.com/ab1ba1ead2975ce4237cd8ffec8f559d223bbe1e/ui/base/ime/input_method_base.h [modify] https://crrev.com/ab1ba1ead2975ce4237cd8ffec8f559d223bbe1e/ui/base/ime/input_method_chromeos.cc [modify] https://crrev.com/ab1ba1ead2975ce4237cd8ffec8f559d223bbe1e/ui/base/ime/input_method_chromeos.h [modify] https://crrev.com/ab1ba1ead2975ce4237cd8ffec8f559d223bbe1e/ui/base/ime/input_method_chromeos_unittest.cc
Comment 1 by varkha@chromium.org
, Jul 24 2017