New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 723781 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Log the power state of adapter with INFO logging level

Project Member Reported by mcchou@chromium.org, May 17 2017

Issue description

The power state change of adapter is currently logged at DEBUG level which doesn't show up in the system log from feedback reports. And this info is important for WiFi debugging in terms of co-ex issue.
 

Comment 1 by mcchou@chromium.org, May 17 2017

Patches:
crosreview.com/508168 (ToT)
crosreview.com/508049 (release-R59-9460.B)
Project Member

Comment 2 by bugdroid1@chromium.org, May 17 2017

Labels: merge-merged-release-R59-9460.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/bluez/+/2893fffbde42917b5994bca569f23c71dcd3dda4

commit 2893fffbde42917b5994bca569f23c71dcd3dda4
Author: Miao-chen Chou <mcchou@chromium.org>
Date: Wed May 17 19:17:53 2017

CHROMIUM: Log the power state change of adapter

This changes the log level of messages in adapter_start() and adapter_stop()
in order to have better visibility on the power state of adapter in
/var/log/messages.

BUG= chromium:723781 
TEST=build, deploy and check /var/log/messages

Change-Id: If2ec798e5285fc1f26fb63eaca7be148c8d868d1
Reviewed-on: https://chromium-review.googlesource.com/508049
Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
Commit-Queue: Miao-chen Chou <mcchou@chromium.org>
Tested-by: Miao-chen Chou <mcchou@chromium.org>
Trybot-Ready: Miao-chen Chou <mcchou@chromium.org>

[modify] https://crrev.com/2893fffbde42917b5994bca569f23c71dcd3dda4/src/adapter.c

Project Member

Comment 3 by sheriffbot@chromium.org, May 18 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, May 20 2017

Labels: merge-merged-chromeos-5.44
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/bluez/+/898f66756430236a234b92142488fc6bd55f921c

commit 898f66756430236a234b92142488fc6bd55f921c
Author: Miao-chen Chou <mcchou@chromium.org>
Date: Sat May 20 10:55:16 2017

CHROMIUM: Log the power state change of adapter

This changes the log level of messages in adapter_start() and adapter_stop()
in order to have better visibility on the power state of adapter in
/var/log/messages.

BUG= chromium:723781 
TEST=build, deploy and check /var/log/messages

Change-Id: If2ec798e5285fc1f26fb63eaca7be148c8d868d1
Reviewed-on: https://chromium-review.googlesource.com/508168
Commit-Ready: Miao-chen Chou <mcchou@chromium.org>
Tested-by: Miao-chen Chou <mcchou@chromium.org>
Reviewed-by: Sameer Nanda <snanda@chromium.org>
Reviewed-by: Miao-chen Chou <mcchou@chromium.org>

[modify] https://crrev.com/898f66756430236a234b92142488fc6bd55f921c/src/adapter.c

Project Member

Comment 5 by sheriffbot@chromium.org, May 22 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, May 26 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by sheriffbot@chromium.org, Jul 10 2017

Labels: -Merge-Approved-59
This issue hasn't been updated in the last 6 weeks, so removing its merge approval label. Please re-request a merge if needed.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by mcchou@chromium.org, Oct 31 2017

Status: Fixed (was: Assigned)

Comment 9 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 10 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
Status: Verified (was: Fixed)

Sign in to add a comment