[iOS] Phone validation should be using the entered country |
|||||||||
Issue description(1) Switch phone to French (Canada) (2) Try to enter a canadian address in the Payment Request editor (android) (3) Phone formatting requires +33 which is in France Should use the entered country (Canada) for phone validation.
,
Jun 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bcfccfe7b5b9b3acdda8f64d1dea9614e2d8f39a commit bcfccfe7b5b9b3acdda8f64d1dea9614e2d8f39a Author: gogerald <gogerald@chromium.org> Date: Wed Jun 21 13:51:37 2017 Format and validate phone number according to selected country in address editor This CL is based on https://codereview.chromium.org/2924513002/ This CL changes the behavior of formatting and validating phone number in address editor if the input number is not starts with '+'. Previously, the phone number is formatted and validated according to region code deduced from the application locale. This causes below issue as described in the bug: (1) Switch phone to French (Canada) (2) Try to enter a canadian address in the Payment Request editor (android) (3) Phone formatting requires +33 which is in France After this patch, the phone number is formatted and validated according to the region code deduced from the selected country code in the address editor. This solves above problem. BUG=723769 Review-Url: https://codereview.chromium.org/2952673002 Cr-Commit-Position: refs/heads/master@{#481193} [modify] https://crrev.com/bcfccfe7b5b9b3acdda8f64d1dea9614e2d8f39a/chrome/android/java/src/org/chromium/chrome/browser/autofill/PhoneNumberUtil.java [modify] https://crrev.com/bcfccfe7b5b9b3acdda8f64d1dea9614e2d8f39a/chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java [modify] https://crrev.com/bcfccfe7b5b9b3acdda8f64d1dea9614e2d8f39a/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java [modify] https://crrev.com/bcfccfe7b5b9b3acdda8f64d1dea9614e2d8f39a/chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java [modify] https://crrev.com/bcfccfe7b5b9b3acdda8f64d1dea9614e2d8f39a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDialog.java [modify] https://crrev.com/bcfccfe7b5b9b3acdda8f64d1dea9614e2d8f39a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java [modify] https://crrev.com/bcfccfe7b5b9b3acdda8f64d1dea9614e2d8f39a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java [modify] https://crrev.com/bcfccfe7b5b9b3acdda8f64d1dea9614e2d8f39a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLoggerTest.java [modify] https://crrev.com/bcfccfe7b5b9b3acdda8f64d1dea9614e2d8f39a/chrome/browser/autofill/android/phone_number_util_android.cc
,
Jun 21 2017
,
Jun 21 2017
,
Jun 21 2017
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b01dc5448d235367e67b6bc4c1e58aa54172fa97 commit b01dc5448d235367e67b6bc4c1e58aa54172fa97 Author: gogerald <gogerald@chromium.org> Date: Wed Jun 21 16:51:45 2017 Update country codes in phone number validator and formatter for editing profile This CL also fixes the bug in this CL https://codereview.chromium.org/2952673002/ to add phone number suggestions. BUG=723769 Review-Url: https://codereview.chromium.org/2945303002 Cr-Commit-Position: refs/heads/master@{#481223} [modify] https://crrev.com/b01dc5448d235367e67b6bc4c1e58aa54172fa97/chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java
,
Jun 21 2017
Too big, too late, not a new regression - rejected for M60.
,
Jun 27 2017
,
Sep 14 2017
Has this been fixed everywhere?
,
Sep 14 2017
+Seb I think he worked on this for Desktop.
,
Sep 15 2017
I've done this on Desktop a while back, it landed/merged into M60. It's working for both the shipping address editor where we have a country to use and the contact info editor where we don't.
,
Sep 15 2017
Can someone verify if this is relevant on iOS?
,
Jan 7
Are you still working on this? Is this still important?
,
Jan 8
I'll keep this logged for iOS where I don't think we do extensive phone validation, but the priority of this is now much lower. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by gogerald@chromium.org
, May 24 2017Owner: wuandy@chromium.org