New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 723768 link

Starred by 2 users
Status: Fixed
Owner:
█ xiaoyinh@chromium.org
Last visit > 30 days ago
Closed: May 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DeviceSettingsService needs to be initialized before using

Project Member Reported by xiaoyinh@chromium.org, May 17 2017 
When we instantiate BrowserPolicyConnectorChromeOS, we should check whether DeviceSettingsService is initialized before using it. See here:
https://cs.chromium.org/chromium/src/chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc?rcl=9de88b53539265b67c4c932f121cb276aca057fd&l=110

This is exposed by this CL: https://codereview.chromium.org/2876673002/
which initialize the SystemSaltGetter in AshTestHelper, and making the if statement for accessing DeviceSettingsService becomes true.
Project Member

Comment 1 by bugdroid1@chromium.org, May 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80eb240f54aa29f667898de5fdd34984a08903d2

commit 80eb240f54aa29f667898de5fdd34984a08903d2
Author: xiaoyinh <xiaoyinh@chromium.org>
Date: Thu May 18 17:09:50 2017

Check DeviceSettingsService is intialized before using.

BUG= 723768 

Review-Url: https://codereview.chromium.org/2891453006
Cr-Commit-Position: refs/heads/master@{#472850}

[modify] https://crrev.com/80eb240f54aa29f667898de5fdd34984a08903d2/chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc

Comment 2 by xiaoyinh@chromium.org, May 18 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment