New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 723742 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

arc: handle task custom icon fro ARC app

Project Member Reported by khmel@chromium.org, May 17 2017

Issue description

Handle Activity.setTaskDescription that provides custom icon for the task.
 

Comment 1 by khmel@chromium.org, May 17 2017

Inner bug: b/36265385
Project Member

Comment 2 by bugdroid1@chromium.org, May 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4821feb1dfd4ad2b98ffc4be0c7deae02fa7e82

commit f4821feb1dfd4ad2b98ffc4be0c7deae02fa7e82
Author: khmel <khmel@chromium.org>
Date: Thu May 25 15:51:00 2017

arc: Set custom icon in shelf for ARC apps.

This handles setTaskDescription requests which provides optional icon
for the task. This CL receives icon from ARC and associates it with
ARC app window. ARC app window contoller receives updates and update
controller item accordingly. If no custom icon set then default app
icon is used.

Preview:
https://drive.google.com/a/google.com/file/d/0B63tZNwdjs-qM3FTYWVJdl9FMDA/view?usp=sharing

TEST=Manually + unit_test
BUG= 723742 

Review-Url: https://codereview.chromium.org/2894443002
Cr-Commit-Position: refs/heads/master@{#474663}

[modify] https://crrev.com/f4821feb1dfd4ad2b98ffc4be0c7deae02fa7e82/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/f4821feb1dfd4ad2b98ffc4be0c7deae02fa7e82/chrome/browser/ui/app_list/arc/arc_app_icon.cc
[modify] https://crrev.com/f4821feb1dfd4ad2b98ffc4be0c7deae02fa7e82/chrome/browser/ui/app_list/arc/arc_app_icon.h
[modify] https://crrev.com/f4821feb1dfd4ad2b98ffc4be0c7deae02fa7e82/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
[modify] https://crrev.com/f4821feb1dfd4ad2b98ffc4be0c7deae02fa7e82/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
[modify] https://crrev.com/f4821feb1dfd4ad2b98ffc4be0c7deae02fa7e82/chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.cc
[modify] https://crrev.com/f4821feb1dfd4ad2b98ffc4be0c7deae02fa7e82/chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.h
[add] https://crrev.com/f4821feb1dfd4ad2b98ffc4be0c7deae02fa7e82/chrome/browser/ui/ash/launcher/arc_app_window.cc
[add] https://crrev.com/f4821feb1dfd4ad2b98ffc4be0c7deae02fa7e82/chrome/browser/ui/ash/launcher/arc_app_window.h
[modify] https://crrev.com/f4821feb1dfd4ad2b98ffc4be0c7deae02fa7e82/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc
[modify] https://crrev.com/f4821feb1dfd4ad2b98ffc4be0c7deae02fa7e82/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h
[modify] https://crrev.com/f4821feb1dfd4ad2b98ffc4be0c7deae02fa7e82/chrome/browser/ui/ash/launcher/arc_app_window_launcher_item_controller.cc
[modify] https://crrev.com/f4821feb1dfd4ad2b98ffc4be0c7deae02fa7e82/chrome/browser/ui/ash/launcher/arc_app_window_launcher_item_controller.h
[modify] https://crrev.com/f4821feb1dfd4ad2b98ffc4be0c7deae02fa7e82/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
[modify] https://crrev.com/f4821feb1dfd4ad2b98ffc4be0c7deae02fa7e82/components/arc/common/app.mojom
[modify] https://crrev.com/f4821feb1dfd4ad2b98ffc4be0c7deae02fa7e82/components/arc/test/fake_app_instance.cc
[modify] https://crrev.com/f4821feb1dfd4ad2b98ffc4be0c7deae02fa7e82/components/arc/test/fake_app_instance.h

Comment 3 by khmel@chromium.org, May 25 2017

Cc: gkihumba@chromium.org
Labels: Merge-Request-59
Project Member

Comment 4 by sheriffbot@chromium.org, May 25 2017

Labels: -Merge-Request-59 Merge-Review-59 Hotlist-Merge-Review
This bug requires manual review: We are only 11 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by gkihumba@google.com, May 31 2017

Labels: Merge-Approved-59

Comment 6 by khmel@chromium.org, Jun 2 2017

Labels: -M-59 -Merge-Review-59 -Merge-Approved-59 M-60
Consider high merge risk and this feature is not blocker for M59, moving target to M60. This code is actually there.

Comment 7 by khmel@chromium.org, Jun 6 2017

Status: Fixed (was: Started)

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment