New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 723739 link

Starred by 1 user
Status: Fixed
Owner:
█ hamelphi@chromium.org
Last visit > 30 days ago
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

[TranslateRanker] Simplify TranslateRanker API

Project Member Reported by hamelphi@chromium.org, May 17 2017 
The TranslateRanker API should only take a TranslateEventProto as input. This would simplify the API as well as ensure consistency between logged data and features used for inference.
Project Member

Comment 1 by bugdroid1@chromium.org, May 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3fe5e855cb0ecae33620fbfbb651ec3e0ed0d96

commit e3fe5e855cb0ecae33620fbfbb651ec3e0ed0d96
Author: hamelphi <hamelphi@chromium.org>
Date: Tue May 23 15:55:56 2017

Simplify TranslateRanker API.

ShoudlOfferTranslate now only requires a TranslateEventProto. This simplifies the API, and ensures consistency between logging and inference.

Also, removing unused includes and cleaning up unittests.

BUG= 723739 

Review-Url: https://codereview.chromium.org/2890843003
Cr-Commit-Position: refs/heads/master@{#473918}

[modify] https://crrev.com/e3fe5e855cb0ecae33620fbfbb651ec3e0ed0d96/components/translate/core/browser/mock_translate_ranker.cc
[modify] https://crrev.com/e3fe5e855cb0ecae33620fbfbb651ec3e0ed0d96/components/translate/core/browser/mock_translate_ranker.h
[modify] https://crrev.com/e3fe5e855cb0ecae33620fbfbb651ec3e0ed0d96/components/translate/core/browser/translate_manager.cc
[modify] https://crrev.com/e3fe5e855cb0ecae33620fbfbb651ec3e0ed0d96/components/translate/core/browser/translate_ranker.h
[modify] https://crrev.com/e3fe5e855cb0ecae33620fbfbb651ec3e0ed0d96/components/translate/core/browser/translate_ranker_impl.cc
[modify] https://crrev.com/e3fe5e855cb0ecae33620fbfbb651ec3e0ed0d96/components/translate/core/browser/translate_ranker_impl.h
[modify] https://crrev.com/e3fe5e855cb0ecae33620fbfbb651ec3e0ed0d96/components/translate/core/browser/translate_ranker_impl_unittest.cc

Comment 2 by hamelphi@chromium.org, May 30 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment