setMediaKeys is undefined when creating an HTMLAudioElement using the Audio constructor
Reported by
justinwi...@spotify.com,
May 17 2017
|
||||||
Issue description
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36
Steps to reproduce the problem:
1. Create an HTMLAudioElement using the `new Audio()` constructor. The instances setMediaKeys property is undefined.
2. Create an HTMLAudioElement using `document.createElement("audio")`. The instances setMediaKeys property is a function.
3. Create another HTMLAudioElement using the `new Audio()` constructor. The instances setMediaKeys property is a function.
What is the expected behavior?
The Audio constructor should always return an HTMLAudioElement with setMediaKeys defined.
What went wrong?
If the first Audio instance is created using the Audio constructor, rather than createElement, it's setMediaKeys property is undefined. However, once an Audio instance is created using createElement, all subsequent calls to the Audio constructor return an HTMLAudioElement with a setMediaKeys function.
Did this work before? Yes 57.0.2987.133
Does this work in other browsers? Yes
Chrome version: 58.0.3029.110 Channel: stable
OS Version: OS X 10.12.4
Flash Version:
Please see attached reduced test case or https://jsfiddle.net/znz285yk/ for an example of the bug
,
May 17 2017
,
May 18 2017
Tested the issue on Windows 7 , mac os 10.12.4 and ubuntu 14.04 using chrome M58 #58.0.3029.110 and issue is reproduced. Issue got fixed in latest beta, dev and canary channels and hence provided the reverse bisect. Using the per-revision bisect providing the bisect results, Good build: 59.0.3037.0 (Revision: 455955). Bad build: 59.0.3035.0 (Revision: 455383). You are probably looking for a change made after 455658 (known good), but no later than 455659 (first known bad). CHANGELOG URL: The script might not always return single CL as suspectas some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/b93e0aca8b783c2fce824dce4b340c5ed7d2108a..a47c72562d1182fb1ee8c62cbc252f9965103d53 From the CL above, assigning the issue to the concern owner @sashab - Could you please merge the fix to M58 . Review-Url: https://codereview.chromium.org/2647643002 Thanks!
,
Jun 19 2017
Sorry, didn't see this somehow :/ yukishiino any ideas?
,
Jun 19 2017
IIUC, sashab@'s CL https://crrev.com/2647643002 **fixed** this issue in M59 (as comment #3 said), and M59 is now stable. So I think that we don't need to merge the CL into M58. As long as no one has an objection, we can just close this issue as Fixed, I think.
,
Dec 20 2017
Based on the comment history here, I'm going to assume that it is fixed. OP, please let us know if it's not the case.
,
Dec 22 2017
Yes, this seems to be working now. Thank you! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by manoranj...@chromium.org
, May 17 2017