Was finding a lot of strings that were just never used while working on other size issues. Need updated find_unused_resources.py command. Currently finding thousands of unused resources. Potentially saving 100s of kbs.
I think this should already be taken care of by the resource whitelisting we do when is_official_build = true (see https://cs.chromium.org/chromium/src/tools/resources/generate_resource_whitelist.gni). It would still be nice to remove resources that aren't used, though I'm not sure we'll see much of a size decrease here.
Discussed with Eric offline, this is for java resources, whereas resource whitelisting is for native.
Also see related: issue 636448
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a23b4bac4b5965383eb17f8c9942ac40e58fdf3e commit a23b4bac4b5965383eb17f8c9942ac40e58fdf3e Author: Peter Wen <wnwen@google.com> Date: Thu May 25 13:52:27 2017 Android: Find unused +drawable resources Previously the regex did not allow for possible ids with + in front. BUG= 723712 Change-Id: Ic0d2c94f5350aeb268216103b890fe5ab7fffa7e Reviewed-on: https://chromium-review.googlesource.com/513884 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#474639} [modify] https://crrev.com/a23b4bac4b5965383eb17f8c9942ac40e58fdf3e/tools/android/find_unused_resources.py
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/af676220578f45293e7ea9cef559db62ebd3c5c5 commit af676220578f45293e7ea9cef559db62ebd3c5c5 Author: Peter Wen <wnwen@google.com> Date: Thu May 25 21:31:28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9704e965f54693bec439544c93126d2ffec0fd2 commit c9704e965f54693bec439544c93126d2ffec0fd2 Author: Peter Wen <wnwen@google.com> Date: Mon May 29 14:20:48 2017 Android: Remove unused resources These resources are unused, estimate savings: 37kb Bug: 723712 Change-Id: I2f67b7c1feffc4be4fefdfcbb0d733014044a985 Reviewed-on: https://chromium-review.googlesource.com/516362 Reviewed-by: Xi Han <hanxi@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Will Harris <wfh@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#475347} [modify] https://crrev.com/c9704e965f54693bec439544c93126d2ffec0fd2/chrome/android/java/res/values/colors.xml [modify] https://crrev.com/c9704e965f54693bec439544c93126d2ffec0fd2/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/c9704e965f54693bec439544c93126d2ffec0fd2/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/c9704e965f54693bec439544c93126d2ffec0fd2/components/new_or_sad_tab_strings.grdp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e071f50ba3e8d0024eb92a019b2c35e223788e32 commit e071f50ba3e8d0024eb92a019b2c35e223788e32 Author: Peter Wen <wnwen@google.com> Date: Mon Jun 05 14:09:34 2017 Android: Find style parents when used Previously styles that were parents of other styles were considered unused by find_unused_resources.py. Now they are marked as used. Bug: 723712 Change-Id: Ib1c822592b6a6c947e26c40495e762df765838fb Reviewed-on: https://chromium-review.googlesource.com/515523 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#476979} [modify] https://crrev.com/e071f50ba3e8d0024eb92a019b2c35e223788e32/tools/android/find_unused_resources.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d0946415c274ca78ee7fef024b1a792584cb591 commit 7d0946415c274ca78ee7fef024b1a792584cb591 Author: Peter Wen <wnwen@google.com> Date: Mon Jun 05 16:29:17 2017 Android: Remove unused resources in chrome_apk These were found using tools/android/find_unused_resources.py. They are no longer used and can be safely deleted. Bug: 723712 Change-Id: Ibc63eafb7aac7469678729607cb9eb9c5d7deacc Reviewed-on: https://chromium-review.googlesource.com/513547 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by: Theresa Wellington <twellington@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#476997} [modify] https://crrev.com/7d0946415c274ca78ee7fef024b1a792584cb591/build/android/lint/suppressions.xml [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-hdpi/account_management_incognito.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-hdpi/bookmark_managed.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-hdpi/btn_recents.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-hdpi/bubble_point_white.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-hdpi/bubble_white.9.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-hdpi/ic_physical_web_notification.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-hdpi/more_horiz.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-hdpi/permission_images.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-hdpi/permission_keygen.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-hdpi/progress_bar_background_white.9.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-mdpi/account_management_incognito.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-mdpi/bookmark_managed.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-mdpi/btn_recents.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-mdpi/bubble_point_white.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-mdpi/bubble_white.9.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-mdpi/ic_physical_web_notification.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-mdpi/more_horiz.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-mdpi/permission_images.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-mdpi/permission_keygen.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-mdpi/progress_bar_background_white.9.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-xhdpi/account_management_incognito.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-xhdpi/bookmark_managed.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-xhdpi/btn_recents.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-xhdpi/bubble_point_white.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-xhdpi/bubble_white.9.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-xhdpi/ic_physical_web_notification.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-xhdpi/more_horiz.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-xhdpi/permission_images.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-xhdpi/permission_keygen.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-xhdpi/progress_bar_background_white.9.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-xxhdpi/account_management_incognito.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-xxhdpi/bookmark_managed.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-xxhdpi/btn_recents.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-xxhdpi/bubble_point_white.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-xxhdpi/bubble_white.9.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-xxhdpi/ic_physical_web_notification.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-xxhdpi/more_horiz.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-xxhdpi/permission_images.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-xxhdpi/permission_keygen.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-xxhdpi/progress_bar_background_white.9.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-xxxhdpi/account_management_incognito.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-xxxhdpi/bookmark_managed.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-xxxhdpi/btn_recents.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-xxxhdpi/bubble_point_white.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-xxxhdpi/bubble_white.9.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-xxxhdpi/ic_physical_web_notification.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-xxxhdpi/permission_images.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-xxxhdpi/permission_keygen.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable-xxxhdpi/progress_bar_background_white.9.png [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable/download_progressbar.xml [delete] https://crrev.com/473dbadd4ff747e39ff9c538b845d35911daa4a3/chrome/android/java/res/drawable/physical_web_scanning_animation.xml
Done removing low-hanging fruit. Improving process bug filed at issue 729677 .
Comment 1 by estevenson@chromium.org
, May 17 2017