We should annotate UKM reports with the transition type into the page navigation. This might map directly to the PageTransition enum defined here: https://codesearch.chromium.org/chromium/src/ui/base/page_transition_types.h?rcl=5f7ac3af3be63d35ecba7c6814c842f4d1c12da3&l=27 In addition, we should annotate when a page was loaded as a reload from a preview, which might mean extending PageTransition, if that's what we use.
This is recorded in Navigation.PageTransition
Changing this bug to track the fact we want opt outs in UKM, not specifically relad information.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1806f8e181472bb2fb3d32ce575c4b2ec8a36bf2 commit 1806f8e181472bb2fb3d32ce575c4b2ec8a36bf2 Author: ryansturm <ryansturm@chromium.org> Date: Mon Jul 17 20:54:03 2017 Adding previews information to PLM UKM This adds four metrics to the PLM UKM for previews: "opt_out", set to true when the user hit "Show Original" on a preview; "server_lofi", "client_lofi", and "lite_page" set to true when a preview was shown. When no preview is shown, no metrics are added to the UKM. Similarly, when the user does not opt out, nothing is added for opt_out. This does not track offline previews yet, but may in the future. The infobar posts an event to page_load_metrics for the web contents when the user clicks "show original" on the page. BUG= 701514 , 723711 ,728707 Review-Url: https://codereview.chromium.org/2952343004 Cr-Commit-Position: refs/heads/master@{#487238} [modify] https://crrev.com/1806f8e181472bb2fb3d32ce575c4b2ec8a36bf2/chrome/browser/BUILD.gn [modify] https://crrev.com/1806f8e181472bb2fb3d32ce575c4b2ec8a36bf2/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc [modify] https://crrev.com/1806f8e181472bb2fb3d32ce575c4b2ec8a36bf2/chrome/browser/page_load_metrics/metrics_web_contents_observer.h [modify] https://crrev.com/1806f8e181472bb2fb3d32ce575c4b2ec8a36bf2/chrome/browser/page_load_metrics/observers/lofi_page_load_metrics_observer_unittest.cc [add] https://crrev.com/1806f8e181472bb2fb3d32ce575c4b2ec8a36bf2/chrome/browser/page_load_metrics/observers/previews_ukm_observer.cc [add] https://crrev.com/1806f8e181472bb2fb3d32ce575c4b2ec8a36bf2/chrome/browser/page_load_metrics/observers/previews_ukm_observer.h [add] https://crrev.com/1806f8e181472bb2fb3d32ce575c4b2ec8a36bf2/chrome/browser/page_load_metrics/observers/previews_ukm_observer_unittest.cc [modify] https://crrev.com/1806f8e181472bb2fb3d32ce575c4b2ec8a36bf2/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc [modify] https://crrev.com/1806f8e181472bb2fb3d32ce575c4b2ec8a36bf2/chrome/browser/page_load_metrics/page_load_metrics_observer.h [modify] https://crrev.com/1806f8e181472bb2fb3d32ce575c4b2ec8a36bf2/chrome/browser/page_load_metrics/page_load_tracker.cc [modify] https://crrev.com/1806f8e181472bb2fb3d32ce575c4b2ec8a36bf2/chrome/browser/page_load_metrics/page_load_tracker.h [modify] https://crrev.com/1806f8e181472bb2fb3d32ce575c4b2ec8a36bf2/chrome/browser/previews/previews_infobar_delegate.cc [modify] https://crrev.com/1806f8e181472bb2fb3d32ce575c4b2ec8a36bf2/chrome/browser/previews/previews_infobar_delegate.h [modify] https://crrev.com/1806f8e181472bb2fb3d32ce575c4b2ec8a36bf2/chrome/browser/previews/previews_infobar_delegate_unittest.cc [modify] https://crrev.com/1806f8e181472bb2fb3d32ce575c4b2ec8a36bf2/chrome/test/BUILD.gn [modify] https://crrev.com/1806f8e181472bb2fb3d32ce575c4b2ec8a36bf2/services/metrics/public/cpp/ukm_recorder.h [modify] https://crrev.com/1806f8e181472bb2fb3d32ce575c4b2ec8a36bf2/tools/metrics/ukm/ukm.xml
Comment 1 by manisca...@chromium.org
, May 18 2017