Issue metadata
Sign in to add a comment
|
(Some?) punctuation stripped from patchset title during upload |
||||||||||||||||||||||
Issue descriptionUploaded a patch to polygerrit where I titled the patchset "Self-review". The patchset appears in polygerrit ( https://chromium-review.googlesource.com/c/505639/ patch 3) as "Selfreview". Obviously minor in this case, but somewhat less readable, and could be a bigger issue later.
,
May 17 2017
,
May 17 2017
,
May 17 2017
To pass the title to Gerrit, git cl upload has to use an encoding that doesn't support a lot of punctuation (the option value is embedded in the name of the "magic" branch you're pushing the code review to). Someday we hope to get support for server options on pushes added to the git wire protocol, so we don't have to depend on this hack. Alternatively, git cl upload could follow up with an API request direct to Gerrit: https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#set-description It could inspect the content of the title and decide which method to use accordingly.
,
May 17 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by pkasting@chromium.org
, May 17 2017