New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 723703 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Record page data size UKM

Project Member Reported by bengr@chromium.org, May 17 2017

Issue description

We should record the size of a Web page including all subresources in all subframes, and ideally including any service worker activity that was directly related to the loading of the page.

At the very least page size should be the sum of received HTTP payloads. Depending on implementation complexity, we should also consider HTTP headers and request payloads.

Data savings should be recorded as the number of bytes there were not loaded due to data savings optimizations provided by the browser, including, but not limited to the compression benefit of the data reduction proxy.
 

Comment 1 by bengr@chromium.org, May 17 2017

Components: Internals>Network>DataUse

Comment 2 by bengr@chromium.org, May 17 2017

Labels: -Type-Bug Type-Feature

Comment 3 by bengr@chromium.org, May 17 2017

Cc: mdw@chromium.org
Cc: manisca...@chromium.org
Cc: jkarlin@chromium.org
To track actual bytes used, let's continue to use the resource tracking API in page load metrics that jkarlin added. We have breakouts by cached bytes and network bytes.
Attributing ServiceWorker requests to a page would be excellent. I'd love to see that added to our existing page size tracking.
Cc: dougarnett@chromium.org
Just to check - will this record data size for all page loads? That is, if there were no data savings? 

This could be helpful to learn of "heavy" HTTPS pages.

[Also, move target to M-62?]
Yes. This will be in core PLM UKM.
Scope creep asks - might be helpful to know: 
  1. if Data Saver is enabled/active for user (even if presence of 0 data savings count vs. no count)
  2. effective connection type (ECT)

The motivation would be to know if page UKM that did not have any preview was a candidate for preview (vs. not Data Saver user or user had fast connection).

Looks like the ECT is available in DataReductionProxyData (same place the applied previews are taken from). And I wonder if there wouldn't be a DataReductionProxyData instance if not a Data Saver user.
Net.EffectiveConnectionType2.OnNavigationStart tracks ECT already.

This bug, AIUI, tracks data usage on the page (net usage and cache usage).

Comment 11 by bengr@chromium.org, Aug 28 2017

Cc: tbansal@chromium.org
Labels: -M-61 M-62
#10: Yes. Also, I'm not sure if you want to do this in the same bug, but we should also record whether data saver was enabled.
Cc: ryansturm@chromium.org
Labels: -M-62 M-64
Owner: dougarnett@chromium.org
This bug looks a bit like a tracking bug for many addition ideas. 

I would like to take it for an initial iteration to add:
  - network bytes
  - cached bytes
  - and maybe whether Data Saver was enabled.

 
Has this been implemented at all? I was looking to file a bug specifically about tracking ads data usage via UKM but if we aren't tracking data usage in general that is good to know.

Comment 14 by bengr@chromium.org, Oct 31 2017

Not yet. Perhaps ryansturm@ can jump on it. Regardless we should keep the efforts in sync.
Summary: Record page data size UKM (was: Record page data size and data savings in UKM)
I split out a seperate bug for data savings.

 crbug.com/780307 
Cc: -ryansturm@chromium.org
Owner: ryansturm@chromium.org
UKM collection approved by privacy.
Project Member

Comment 19 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9190ef1c39a78dedf9c21998dad98ac65abef2b0

commit 9190ef1c39a78dedf9c21998dad98ac65abef2b0
Author: Ryan Sturm <ryansturm@chromium.org>
Date: Tue Dec 12 20:59:26 2017

Adding PLM UKM for body size

This tracks network and cache bytes and rounds them to a lower bounding
exponential bucket threshold before reporting them to UKM.

Bug:  723703 
Change-Id: Ica14f0c7e396c9086e71f6cdc3c9b869cf75d0a8
Reviewed-on: https://chromium-review.googlesource.com/791529
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523533}
[modify] https://crrev.com/9190ef1c39a78dedf9c21998dad98ac65abef2b0/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc
[modify] https://crrev.com/9190ef1c39a78dedf9c21998dad98ac65abef2b0/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
[modify] https://crrev.com/9190ef1c39a78dedf9c21998dad98ac65abef2b0/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/9190ef1c39a78dedf9c21998dad98ac65abef2b0/services/metrics/public/cpp/BUILD.gn
[add] https://crrev.com/9190ef1c39a78dedf9c21998dad98ac65abef2b0/services/metrics/public/cpp/metrics_utils.cc
[add] https://crrev.com/9190ef1c39a78dedf9c21998dad98ac65abef2b0/services/metrics/public/cpp/metrics_utils.h
[modify] https://crrev.com/9190ef1c39a78dedf9c21998dad98ac65abef2b0/tools/metrics/ukm/ukm.xml

Status: Fixed (was: Assigned)
Labels: -M-64 M-65

Sign in to add a comment